Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash
Date: Thu, 28 Jun 2018 13:07:59 +0300	[thread overview]
Message-ID: <20180628100759.45clx3diuv6tk3e3@tarshish> (raw)
In-Reply-To: <20180628095113.GC17271@n2100.armlinux.org.uk>

Hi Russell,

Thanks for reviewing.

On Thu, Jun 28, 2018 at 10:51:14AM +0100, Russell King - ARM Linux wrote:
> On Thu, Jun 28, 2018 at 10:13:35AM +0300, Baruch Siach wrote:
> > The SolidRun Armada 388 SOM has the SPI flash populated by default
> > unless the customer explicitly asks otherwise. Enable support by
> > default.
> 
> Are you sure about that - at least some of my boards do not have the
> SPI flash populated.
> 
> &spi1 {
>         /* The microsom has an optional W25Q32 on board, connected to CS0 */
> ...
> &spi1 {
>         /*
>          * Add SPI CS pins for clearfog:
>          * CS0: W25Q32 (not populated on uSOM)

I should update this line as well, I guess.

>          * CS1: PIC microcontroller (Pro models)
>          * CS2: mikrobus
>          */
> 
> I wouldn't have written "not populated on uSOM" without having first
> taken the uSOM off and physically checked.

Are these production SOMs or development/engineering samples?

Ilya Viten from the SolidRun commercial department told me that all production 
SOMs that were shipped to customers have the SPI flash populated.

This is just the default value for the common case.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

  reply	other threads:[~2018-06-28 10:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-28  7:13 [PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash Baruch Siach
2018-06-28  7:13 ` [PATCH 2/2] ARM: dts: armada388-clearfog: drop future changes disclaimer Baruch Siach
2018-06-28  8:22   ` Andrew Lunn
2018-06-28  8:33     ` Jon Nettleton
2018-06-28  8:47       ` Andrew Lunn
2018-06-28  9:11   ` Andrew Lunn
2018-06-28  9:33   ` Gregory CLEMENT
2018-06-28  9:31 ` [PATCH 1/2] ARM: dts: armada388-clearfog: enable spi flash Gregory CLEMENT
2018-06-28  9:52   ` Russell King - ARM Linux
2018-06-28  9:56     ` Gregory CLEMENT
2018-06-28  9:51 ` Russell King - ARM Linux
2018-06-28 10:07   ` Baruch Siach [this message]
2018-06-28 10:33     ` Russell King - ARM Linux
2018-06-28 10:47       ` Baruch Siach
2018-06-28 11:13         ` Russell King - ARM Linux
2018-06-28 11:38           ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180628100759.45clx3diuv6tk3e3@tarshish \
    --to=baruch@tkos.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox