* [PATCH v2] arm64: dts: marvell: armada-37xx: reserve memory for ATF
@ 2018-06-26 8:17 Miquel Raynal
2018-06-29 11:44 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Miquel Raynal @ 2018-06-26 8:17 UTC (permalink / raw)
To: linux-arm-kernel
From: Victor Gu <xigu@marvell.com>
The PSCI area should be reserved in Linux for PSCI operations such as
suspend/resume.
Reserve 2MiB of memory which matches the area used by ATF (BL1, BL2,
BL3x, see [1] in ATF source code). This covers all PSCI code and data
area and is 2MiB aligned, which is required by Linux for huge pages
handling.
Please note that this is a default setup allowing to perform PSCI
operations with legacy bootloaders. Recent bootloaders should update the
region size/position accordingly.
[1] plat/marvell/a3700/common/include/platform_def.h
Signed-off-by: Victor Gu <xigu@marvell.com>
[miquel.raynal at bootlin.com: reword of commit message, comment in the DTSI]
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
Changes since v1:
=================
* Updated commit log to explain that this memory region should be
updated by recent bootloaders.
* Added a comment to tell the same thing above the psci-area subnode.
arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index 3353252d78a0..d18a4a098d79 100644
--- a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
+++ b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
@@ -22,6 +22,21 @@
serial1 = &uart1;
};
+ reserved-memory {
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
+
+ /*
+ * The PSCI firmware region depicted below is the default one
+ * and should be updated by the bootloader.
+ */
+ psci-area at 4000000 {
+ reg = <0 0x4000000 0 0x200000>;
+ no-map;
+ };
+ };
+
cpus {
#address-cells = <1>;
#size-cells = <0>;
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v2] arm64: dts: marvell: armada-37xx: reserve memory for ATF
2018-06-26 8:17 [PATCH v2] arm64: dts: marvell: armada-37xx: reserve memory for ATF Miquel Raynal
@ 2018-06-29 11:44 ` Thomas Petazzoni
2018-06-29 14:39 ` Gregory CLEMENT
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2018-06-29 11:44 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Tue, 26 Jun 2018 10:17:01 +0200, Miquel Raynal wrote:
> From: Victor Gu <xigu@marvell.com>
>
> The PSCI area should be reserved in Linux for PSCI operations such as
> suspend/resume.
>
> Reserve 2MiB of memory which matches the area used by ATF (BL1, BL2,
> BL3x, see [1] in ATF source code). This covers all PSCI code and data
> area and is 2MiB aligned, which is required by Linux for huge pages
> handling.
>
> Please note that this is a default setup allowing to perform PSCI
> operations with legacy bootloaders. Recent bootloaders should update the
> region size/position accordingly.
>
> [1] plat/marvell/a3700/common/include/platform_def.h
>
> Signed-off-by: Victor Gu <xigu@marvell.com>
> [miquel.raynal at bootlin.com: reword of commit message, comment in the DTSI]
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] arm64: dts: marvell: armada-37xx: reserve memory for ATF
2018-06-29 11:44 ` Thomas Petazzoni
@ 2018-06-29 14:39 ` Gregory CLEMENT
0 siblings, 0 replies; 3+ messages in thread
From: Gregory CLEMENT @ 2018-06-29 14:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Miquel, Thomas,
On ven., juin 29 2018, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello,
>
> On Tue, 26 Jun 2018 10:17:01 +0200, Miquel Raynal wrote:
>> From: Victor Gu <xigu@marvell.com>
>>
>> The PSCI area should be reserved in Linux for PSCI operations such as
>> suspend/resume.
>>
>> Reserve 2MiB of memory which matches the area used by ATF (BL1, BL2,
>> BL3x, see [1] in ATF source code). This covers all PSCI code and data
>> area and is 2MiB aligned, which is required by Linux for huge pages
>> handling.
>>
>> Please note that this is a default setup allowing to perform PSCI
>> operations with legacy bootloaders. Recent bootloaders should update the
>> region size/position accordingly.
>>
>> [1] plat/marvell/a3700/common/include/platform_def.h
>>
>> Signed-off-by: Victor Gu <xigu@marvell.com>
>> [miquel.raynal at bootlin.com: reword of commit message, comment in the DTSI]
>> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
>
> Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Applied on mvebu/dt64
Thanks,
Gregory
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-29 14:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-26 8:17 [PATCH v2] arm64: dts: marvell: armada-37xx: reserve memory for ATF Miquel Raynal
2018-06-29 11:44 ` Thomas Petazzoni
2018-06-29 14:39 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).