* [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy
@ 2018-06-28 4:37 Andrey Smirnov
2018-06-28 4:37 ` [PATCH 2/2] ARM: dts: imx51-babbage: Make use of pinctrl_usbh1reg Andrey Smirnov
2018-06-28 13:35 ` [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy Fabio Estevam
0 siblings, 2 replies; 6+ messages in thread
From: Andrey Smirnov @ 2018-06-28 4:37 UTC (permalink / raw)
To: linux-arm-kernel
There's already a USB PHY with reg of zero on that bus - usbphy0, used
by usbotg (included from imx51.dtsi). Move usbh1phy to @1 avoid
address collision.
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boot/dts/imx51-babbage.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
index b8ca73d3d379..541c6e67ad1a 100644
--- a/arch/arm/boot/dts/imx51-babbage.dts
+++ b/arch/arm/boot/dts/imx51-babbage.dts
@@ -175,9 +175,9 @@
#size-cells = <0>;
compatible = "simple-bus";
- usbh1phy: usbh1phy at 0 {
+ usbh1phy: usbh1phy at 1 {
compatible = "usb-nop-xceiv";
- reg = <0>;
+ reg = <1>;
clocks = <&clk_usb>;
clock-names = "main_clk";
reset-gpios = <&gpio2 5 GPIO_ACTIVE_LOW>;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: dts: imx51-babbage: Make use of pinctrl_usbh1reg
2018-06-28 4:37 [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy Andrey Smirnov
@ 2018-06-28 4:37 ` Andrey Smirnov
2018-06-28 13:33 ` Fabio Estevam
2018-07-03 5:45 ` Shawn Guo
2018-06-28 13:35 ` [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy Fabio Estevam
1 sibling, 2 replies; 6+ messages in thread
From: Andrey Smirnov @ 2018-06-28 4:37 UTC (permalink / raw)
To: linux-arm-kernel
Pinctrl_usbh1reg defines pinmux setting for reset GPIO used by
usbh1phy, but is not referenced by that node. Fix that.
Cc: Fabio Estevam <fabio.estevam@nxp.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-kernel at vger.kernel.org
Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
---
arch/arm/boot/dts/imx51-babbage.dts | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
index 541c6e67ad1a..19d3f0127f91 100644
--- a/arch/arm/boot/dts/imx51-babbage.dts
+++ b/arch/arm/boot/dts/imx51-babbage.dts
@@ -177,6 +177,8 @@
usbh1phy: usbh1phy at 1 {
compatible = "usb-nop-xceiv";
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_usbh1reg>;
reg = <1>;
clocks = <&clk_usb>;
clock-names = "main_clk";
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: dts: imx51-babbage: Make use of pinctrl_usbh1reg
2018-06-28 4:37 ` [PATCH 2/2] ARM: dts: imx51-babbage: Make use of pinctrl_usbh1reg Andrey Smirnov
@ 2018-06-28 13:33 ` Fabio Estevam
2018-07-03 5:45 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-06-28 13:33 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 28, 2018 at 1:37 AM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> Pinctrl_usbh1reg defines pinmux setting for reset GPIO used by
> usbh1phy, but is not referenced by that node. Fix that.
>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: dts: imx51-babbage: Make use of pinctrl_usbh1reg
2018-06-28 4:37 ` [PATCH 2/2] ARM: dts: imx51-babbage: Make use of pinctrl_usbh1reg Andrey Smirnov
2018-06-28 13:33 ` Fabio Estevam
@ 2018-07-03 5:45 ` Shawn Guo
1 sibling, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2018-07-03 5:45 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 27, 2018 at 09:37:13PM -0700, Andrey Smirnov wrote:
> Pinctrl_usbh1reg defines pinmux setting for reset GPIO used by
> usbh1phy, but is not referenced by that node. Fix that.
>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy
2018-06-28 4:37 [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy Andrey Smirnov
2018-06-28 4:37 ` [PATCH 2/2] ARM: dts: imx51-babbage: Make use of pinctrl_usbh1reg Andrey Smirnov
@ 2018-06-28 13:35 ` Fabio Estevam
2018-06-29 0:53 ` Andrey Smirnov
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2018-06-28 13:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Andrey,
On Thu, Jun 28, 2018 at 1:37 AM, Andrey Smirnov
<andrew.smirnov@gmail.com> wrote:
> There's already a USB PHY with reg of zero on that bus - usbphy0, used
> by usbotg (included from imx51.dtsi). Move usbh1phy to @1 avoid
> address collision.
>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
> arch/arm/boot/dts/imx51-babbage.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
> index b8ca73d3d379..541c6e67ad1a 100644
> --- a/arch/arm/boot/dts/imx51-babbage.dts
> +++ b/arch/arm/boot/dts/imx51-babbage.dts
> @@ -175,9 +175,9 @@
> #size-cells = <0>;
> compatible = "simple-bus";
>
> - usbh1phy: usbh1phy at 0 {
> + usbh1phy: usbh1phy at 1 {
> compatible = "usb-nop-xceiv";
> - reg = <0>;
> + reg = <1>;
We don't really need the 'reg' property here.
I have sent a previous fix for this on an attempt to fix dtc warnings
with W=1, so let me send a v2 based on the feedback I got previously:
https://patchwork.kernel.org/patch/10399085/
Thanks
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy
2018-06-28 13:35 ` [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy Fabio Estevam
@ 2018-06-29 0:53 ` Andrey Smirnov
0 siblings, 0 replies; 6+ messages in thread
From: Andrey Smirnov @ 2018-06-29 0:53 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jun 28, 2018 at 6:35 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Andrey,
>
> On Thu, Jun 28, 2018 at 1:37 AM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
> > There's already a USB PHY with reg of zero on that bus - usbphy0, used
> > by usbotg (included from imx51.dtsi). Move usbh1phy to @1 avoid
> > address collision.
> >
> > Cc: Fabio Estevam <fabio.estevam@nxp.com>
> > Cc: Shawn Guo <shawnguo@kernel.org>
> > Cc: linux-arm-kernel at lists.infradead.org
> > Cc: linux-kernel at vger.kernel.org
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > ---
> > arch/arm/boot/dts/imx51-babbage.dts | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/imx51-babbage.dts b/arch/arm/boot/dts/imx51-babbage.dts
> > index b8ca73d3d379..541c6e67ad1a 100644
> > --- a/arch/arm/boot/dts/imx51-babbage.dts
> > +++ b/arch/arm/boot/dts/imx51-babbage.dts
> > @@ -175,9 +175,9 @@
> > #size-cells = <0>;
> > compatible = "simple-bus";
> >
> > - usbh1phy: usbh1phy at 0 {
> > + usbh1phy: usbh1phy at 1 {
> > compatible = "usb-nop-xceiv";
> > - reg = <0>;
> > + reg = <1>;
>
> We don't really need the 'reg' property here.
>
> I have sent a previous fix for this on an attempt to fix dtc warnings
> with W=1, so let me send a v2 based on the feedback I got previously:
> https://patchwork.kernel.org/patch/10399085/
OK, cool, good to hear. Please disregard this patch in that case.
Thanks,
Andrey Smirnov
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-03 5:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-28 4:37 [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy Andrey Smirnov
2018-06-28 4:37 ` [PATCH 2/2] ARM: dts: imx51-babbage: Make use of pinctrl_usbh1reg Andrey Smirnov
2018-06-28 13:33 ` Fabio Estevam
2018-07-03 5:45 ` Shawn Guo
2018-06-28 13:35 ` [PATCH 1/2] ARM: dts: imx51-babbage: Fix reg for usbh1phy Fabio Estevam
2018-06-29 0:53 ` Andrey Smirnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).