From: jolsa@redhat.com (Jiri Olsa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] perf/core: Use ioctl to communicate driver configuration to kernel
Date: Tue, 3 Jul 2018 15:40:26 +0200 [thread overview]
Message-ID: <20180703134026.GA3728@krava> (raw)
In-Reply-To: <1530570810-28929-6-git-send-email-mathieu.poirier@linaro.org>
On Mon, Jul 02, 2018 at 04:33:29PM -0600, Mathieu Poirier wrote:
SNIP
> +static int
> +perf_event_process_drv_config(struct perf_event *event, char *config_str)
> +{
> + int ret = -EINVAL;
> + void *drv_data;
> +
> + /* Make sure ctx.mutex it held */
> + lockdep_assert_held(&event->ctx->mutex);
> +
> + /* Children take their configuration from their parent */
> + if (WARN_ON_ONCE(event->parent))
> + goto out;
> +
> + drv_data = event->pmu->drv_config_validate(event, config_str);
> + if (!drv_data)
> + goto out;
what's this check for? doc does not mention that,
also the coresight callback does not return NULL
jirka
next prev parent reply other threads:[~2018-07-03 13:40 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 22:33 [PATCH 0/6] perf: Add ioctl for PMU driver configuration Mathieu Poirier
2018-07-02 22:33 ` [PATCH 1/6] perf tools: Use ioctl to communicate driver configuration to kernel Mathieu Poirier
2018-07-02 22:33 ` [PATCH 2/6] perf tools: Make perf_evsel accessible to PMU driver configuration code Mathieu Poirier
2018-07-02 22:33 ` [PATCH 3/6] perf tools: Use ioctl function to send sink configuration to kernel Mathieu Poirier
2018-07-02 22:33 ` [PATCH 4/6] perf/aux: Make perf_event accessible to setup_aux() Mathieu Poirier
2018-07-03 2:05 ` kbuild test robot
2018-07-03 7:31 ` Hendrik Brueckner
2018-07-03 17:37 ` Mathieu Poirier
2018-07-03 9:27 ` Alexander Shishkin
2018-07-02 22:33 ` [PATCH 5/6] perf/core: Use ioctl to communicate driver configuration to kernel Mathieu Poirier
2018-07-03 10:03 ` Alexander Shishkin
2018-07-03 10:56 ` Alexander Shishkin
2018-07-03 22:00 ` Mathieu Poirier
2018-07-04 10:34 ` Alexander Shishkin
2018-07-04 21:39 ` Mathieu Poirier
2018-07-03 20:30 ` Mathieu Poirier
2018-07-04 10:51 ` Alexander Shishkin
2018-07-03 22:03 ` Mathieu Poirier
2018-07-03 13:40 ` Jiri Olsa [this message]
2018-07-03 17:47 ` Mathieu Poirier
2018-07-03 13:41 ` Jiri Olsa
2018-07-02 22:33 ` [PATCH 6/6] coresight: Use PMU driver configuration for sink selection Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180703134026.GA3728@krava \
--to=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).