From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] kvm/arm: use PSR_AA32 definitions
Date: Wed, 4 Jul 2018 15:01:22 +0100 [thread overview]
Message-ID: <20180704140121.GD4828@arm.com> (raw)
In-Reply-To: <a0920dc3-0b70-2c39-e2b5-5c23030dd8d0@arm.com>
On Wed, Jul 04, 2018 at 02:23:05PM +0100, Marc Zyngier wrote:
> On 04/07/18 14:12, Will Deacon wrote:
> > On Mon, Jun 25, 2018 at 03:44:20PM +0100, Mark Rutland wrote:
> >> Some code cares about the SPSR_ELx format for exceptions taken from
> >> AArch32 to inspect or manipulate the SPSR_ELx value, which is already in
> >> the SPSR_ELx format, and not in the AArch32 PSR format.
> >>
> >> To separate these from cases where we care about the AArch32 PSR format,
> >> migrate these cases to use the PSR_AA32_* definitions rather than
> >> COMPAT_PSR_*.
> >>
> >> There should be no functional change as a result of this patch.
> >>
> >> Note that arm64 KVM does not support a compat KVM API, and always uses
> >> the SPSR_ELx format, even for AArch32 guests.
> >>
> >> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> >> Cc: Christoffer Dall <christoffer.dall@arm.com>
> >> Cc: Marc Zyngier <marc.zyngier@arm.com>
> >> ---
> >> arch/arm/include/asm/kvm_emulate.h | 14 +++++++-------
> >> arch/arm64/include/asm/kvm_emulate.h | 10 +++++-----
> >> arch/arm64/kvm/guest.c | 14 +++++++-------
> >> arch/arm64/kvm/hyp/vgic-v2-cpuif-proxy.c | 2 +-
> >> arch/arm64/kvm/regmap.c | 22 +++++++++++-----------
> >> arch/arm64/kvm/reset.c | 4 ++--
> >> virt/kvm/arm/aarch32.c | 20 ++++++++++----------
> >> 7 files changed, 43 insertions(+), 43 deletions(-)
> >
> > I need an ack from the KVM maintainers before I can take this. I can also
> > put this series on a separate branch if necessary.
>
> Feel free to add my
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>
> I don't have much queued for KVM ATM, so there is no need for a separate
> branch. Pending stuff shouldn't conflict (famous last word...).
Brill; thanks for the quick reply, Marc.
Will
next prev parent reply other threads:[~2018-07-04 14:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-25 14:44 [PATCH 0/7] arm64: PSR <-> SPSR_ELx mapping fixes Mark Rutland
2018-06-25 14:44 ` [PATCH 1/7] arm64: add PSR_AA32_* definitions Mark Rutland
2018-06-25 14:44 ` [PATCH 2/7] arm64: don't zero DIT on signal return Mark Rutland
2018-06-25 14:44 ` [PATCH 3/7] arm64: compat: map SPSR_ELx<->PSR for signals Mark Rutland
2018-06-25 16:15 ` Suzuki K Poulose
2018-06-25 16:19 ` Mark Rutland
2018-06-25 14:44 ` [PATCH 4/7] arm64: ptrace: map SPSR_ELx<->PSR for compat tasks Mark Rutland
2018-06-25 14:44 ` [PATCH 5/7] arm64: use PSR_AA32 definitions Mark Rutland
2018-06-25 14:44 ` [PATCH 6/7] kvm/arm: " Mark Rutland
2018-07-04 13:12 ` Will Deacon
2018-07-04 13:23 ` Marc Zyngier
2018-07-04 14:01 ` Will Deacon [this message]
2018-07-04 15:06 ` Christoffer Dall
2018-06-25 14:44 ` [PATCH 7/7] arm64: remove unused COMPAT_PSR definitions Mark Rutland
2018-07-04 17:33 ` [PATCH 0/7] arm64: PSR <-> SPSR_ELx mapping fixes Will Deacon
2018-07-05 12:08 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180704140121.GD4828@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).