From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Wed, 4 Jul 2018 17:30:37 +0100 Subject: [PATCH 2/3] arm64: add endianness option to LDFLAGS instead of LD In-Reply-To: <1530580921-23340-3-git-send-email-yamada.masahiro@socionext.com> References: <1530580921-23340-1-git-send-email-yamada.masahiro@socionext.com> <1530580921-23340-3-git-send-email-yamada.masahiro@socionext.com> Message-ID: <20180704163036.GA8370@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jul 03, 2018 at 10:22:00AM +0900, Masahiro Yamada wrote: > With the recent syntax extension, Kconfig is now able to evaluate the > compiler / toolchain capability. > > However, accumulating flags to 'LD' is not compatible with the way > it works; 'LD' must be passed to Kconfig to call $(ld-option,...) > from Kconfig files. If you tweak 'LD' in arch Makefile depending on > CONFIG_CPU_BIG_ENDIAN, this would end up with circular dependency > between Makefile and Kconfig. > > Signed-off-by: Masahiro Yamada > --- Acked-by: Will Deacon But note that this will conflict with: http://lists.infradead.org/pipermail/linux-arm-kernel/2018-July/587726.html Catalin -- I'm assuming you're taking both of these and will resolve the conflict in the arm64 for-next/fixes branch. Cheers, Will > arch/arm64/Makefile | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile > index 4527226..8f73da3 100644 > --- a/arch/arm64/Makefile > +++ b/arch/arm64/Makefile > @@ -60,15 +60,13 @@ ifeq ($(CONFIG_CPU_BIG_ENDIAN), y) > KBUILD_CPPFLAGS += -mbig-endian > CHECKFLAGS += -D__AARCH64EB__ > AS += -EB > -LD += -EB > -LDFLAGS += -maarch64linuxb > +LDFLAGS += -EB -maarch64linuxb > UTS_MACHINE := aarch64_be > else > KBUILD_CPPFLAGS += -mlittle-endian > CHECKFLAGS += -D__AARCH64EL__ > AS += -EL > -LD += -EL > -LDFLAGS += -maarch64linux > +LDFLAGS += -EL -maarch64linux > UTS_MACHINE := aarch64 > endif > > -- > 2.7.4 >