From: oleg@redhat.com (Oleg Nesterov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 06/10] Uprobes: Support SDT markers having reference count (semaphore)
Date: Tue, 10 Jul 2018 17:25:27 +0200 [thread overview]
Message-ID: <20180710152527.GA3616@redhat.com> (raw)
In-Reply-To: <f5a39a88-c21e-4606-a04d-11b5f32016b8@linux.ibm.com>
Hi Ravi,
On 07/04, Ravi Bangoria wrote:
>
> > Now I understand what did you mean by "for each consumer". So if we move this logic
> > into install/remove_breakpoint as I tried to suggest, we will also need another error
> > code for the case when verify_opcode() returns false.
>
> Ok so if we can use verify_opcode() inside install_breakpoint(), we can probably
> move implementation logic in install/remove_breakpoint(). Let me explore that more.
No, sorry for confusion, I meant another thing... But please forget. If we rely on
verify_opcode() I no longer think it would be more clean to move this logic into
install/remove_breakpoint.
However, I still think it would be better to avoid uprobe exporting and modifying
set_swbp/set_orig_insn. May be we can simply kill both set_swbp() and set_orig_insn(),
I'll re-check...
Oleg.
next prev parent reply other threads:[~2018-07-10 15:25 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 5:21 [PATCH v5 00/10] Uprobes: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 01/10] Uprobes: Move uprobe structure to uprobe.h Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 02/10] Uprobes: Simplify uprobe_register() body Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 03/10] Uprobe: Change set_swbp definition Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 04/10] Uprobe: Change set_orig_insn definition Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 05/10] Uprobe: Change uprobe_write_opcode definition Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 06/10] Uprobes: Support SDT markers having reference count (semaphore) Ravi Bangoria
2018-06-28 19:51 ` Oleg Nesterov
2018-06-29 3:23 ` Ravi Bangoria
2018-07-01 21:09 ` Oleg Nesterov
2018-07-02 5:16 ` Ravi Bangoria
2018-07-02 18:01 ` Oleg Nesterov
2018-07-03 5:30 ` Ravi Bangoria
2018-07-03 6:16 ` Srikar Dronamraju
2018-07-03 7:43 ` Ravi Bangoria
2018-07-04 9:16 ` Srikar Dronamraju
2018-07-04 9:24 ` Ravi Bangoria
2018-07-03 8:11 ` Ravi Bangoria
2018-07-03 16:36 ` Oleg Nesterov
2018-07-03 17:25 ` Oleg Nesterov
2018-07-04 4:53 ` Ravi Bangoria
2018-07-10 15:25 ` Oleg Nesterov [this message]
2018-07-11 8:44 ` Ravi Bangoria
2018-07-11 9:52 ` Ravi Bangoria
2018-07-12 14:58 ` Oleg Nesterov
2018-07-12 19:53 ` Song Liu
2018-07-13 7:55 ` Ravi Bangoria
2018-07-13 23:50 ` Song Liu
2018-07-16 8:20 ` Ravi Bangoria
2018-07-16 8:51 ` Ravi Bangoria
2018-07-13 5:39 ` Ravi Bangoria
2018-07-04 4:49 ` Ravi Bangoria
2018-07-03 17:12 ` Oleg Nesterov
2018-07-03 18:23 ` Oleg Nesterov
2018-07-04 5:25 ` Ravi Bangoria
2018-07-02 16:01 ` Srikar Dronamraju
2018-07-02 18:05 ` Oleg Nesterov
2018-07-03 6:29 ` Ravi Bangoria
2018-07-03 19:26 ` Oleg Nesterov
2018-07-04 5:26 ` Ravi Bangoria
2018-07-04 6:07 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 07/10] trace_uprobe/sdt: Prevent multiple reference counter for same uprobe Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 08/10] Uprobes/sdt: " Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 09/10] Uprobes/sdt: Document about reference counter Ravi Bangoria
2018-07-02 14:54 ` Srikar Dronamraju
2018-07-03 7:50 ` Ravi Bangoria
2018-06-28 5:22 ` [PATCH v5 10/10] perf probe: Support SDT markers having reference counter (semaphore) Ravi Bangoria
2018-07-02 14:45 ` Srikar Dronamraju
2018-07-02 14:57 ` Srikar Dronamraju
2018-07-03 8:00 ` Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180710152527.GA3616@redhat.com \
--to=oleg@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).