From mboxrd@z Thu Jan 1 00:00:00 1970 From: manivannan.sadhasivam@linaro.org (Manivannan Sadhasivam) Date: Sun, 15 Jul 2018 19:45:51 +0530 Subject: [PATCH v4 1/5] clk: actions: Add REGMAP as dependency In-Reply-To: References: <20180715123145.16975-1-sravanhome@gmail.com> <20180715123145.16975-2-sravanhome@gmail.com> Message-ID: <20180715141551.GA9980@Mani-XPS-13-9360> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On Sun, Jul 15, 2018 at 02:35:53PM +0200, Andreas F?rber wrote: > Hi, > > Am 15.07.2018 um 14:31 schrieb Saravanan Sekar: > > Add REGMAP as dependency to avoid undefined reference to regmap symbol > > Is this a bugfix for S900? Then please add a Fixes: line. If not, why is > it a separate patch and not in 3/5? > Yes, this is a bug fix for S900 clk and should have Fixes tag. Thanks, Mani > Also, the subject is fine as is, but please add a full stop at the end > of the sentence in the commit message. > > Regards, > Andreas > > > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany > GF: Felix Imend?rffer, Jane Smithard, Graham Norton > HRB 21284 (AG N?rnberg)