linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
Date: Thu, 19 Jul 2018 11:20:03 +0800	[thread overview]
Message-ID: <20180719032002.GT4576@dragon> (raw)
In-Reply-To: <1531896889-21377-1-git-send-email-Anson.Huang@nxp.com>

On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> this patch adds it.
> 
> Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

In general, when you send a patch fixing a commit, you should have the
author of that commit copied.  I added Viresh here.

It looks like a wrong fix to me.  It seems that commit b97872d4eb22
shouldn't change imx7d.dtsi at all.  So the correct fix would be
reverting the change on imx7d.dtsi, @Viresh?

Shawn

> ---
>  arch/arm/boot/dts/imx7d.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 9a772fc..30a1a73 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -9,6 +9,11 @@
>  / {
>  	cpus {
>  		cpu0: cpu at 0 {
> +			operating-points = <
> +				/* KHz	uV */
> +				996000	1075000
> +				792000	975000
> +			>;
>  			clock-frequency = <996000000>;
>  			operating-points-v2 = <&cpu0_opp_table>;
>  			#cooling-cells = <2>;
> -- 
> 2.7.4
> 

  reply	other threads:[~2018-07-19  3:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18  6:54 [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0 Anson Huang
2018-07-19  3:20 ` Shawn Guo [this message]
2018-07-19  3:24   ` Viresh Kumar
2018-07-19  3:26     ` Shawn Guo
2018-07-19  3:32       ` Viresh Kumar
2018-07-19  8:29   ` Anson Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719032002.GT4576@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).