[PATCH] ARM: dts: imx7d: add missing OPP property for cpu0

[PATCH] ARM: dts: imx7d: add missing OPP property for cpu0

[Anson Huang]

Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
this patch adds it.

Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 arch/arm/boot/dts/imx7d.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 9a772fc..30a1a73 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -9,6 +9,11 @@
 / {
 	cpus {
 		cpu0: cpu at 0 {
+			operating-points = <
+				/* KHz	uV */
+				996000	1075000
+				792000	975000
+			>;
 			clock-frequency = <996000000>;
 			operating-points-v2 = <&cpu0_opp_table>;
 			#cooling-cells = <2>;
-- 
2.7.4

[PATCH] ARM: dts: imx7d: add missing OPP property for cpu0

[Shawn Guo]

On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> this patch adds it.
> 
> Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>

In general, when you send a patch fixing a commit, you should have the
author of that commit copied.  I added Viresh here.

It looks like a wrong fix to me.  It seems that commit b97872d4eb22
shouldn't change imx7d.dtsi at all.  So the correct fix would be
reverting the change on imx7d.dtsi, @Viresh?

Shawn

> ---
>  arch/arm/boot/dts/imx7d.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 9a772fc..30a1a73 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -9,6 +9,11 @@
>  / {
>  	cpus {
>  		cpu0: cpu at 0 {
> +			operating-points = <
> +				/* KHz	uV */
> +				996000	1075000
> +				792000	975000
> +			>;
>  			clock-frequency = <996000000>;
>  			operating-points-v2 = <&cpu0_opp_table>;
>  			#cooling-cells = <2>;
> -- 
> 2.7.4
> 

[PATCH] ARM: dts: imx7d: add missing OPP property for cpu0

[Viresh Kumar]

On 19-07-18, 11:20, Shawn Guo wrote:
> On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> > this patch adds it.
> > 
> > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 
> In general, when you send a patch fixing a commit, you should have the
> author of that commit copied.  I added Viresh here.
> 
> It looks like a wrong fix to me.  It seems that commit b97872d4eb22
> shouldn't change imx7d.dtsi at all.  So the correct fix would be
> reverting the change on imx7d.dtsi, @Viresh?

Wow! Can't believe such a stupid mistake got merged and no one noticed
:(

Please revert that patch and I will resend the right fix Shawn.

-- 
viresh

[PATCH] ARM: dts: imx7d: add missing OPP property for cpu0

[Shawn Guo]

On Thu, Jul 19, 2018 at 08:54:54AM +0530, Viresh Kumar wrote:
> On 19-07-18, 11:20, Shawn Guo wrote:
> > On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > > added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> > > this patch adds it.
> > > 
> > > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > 
> > In general, when you send a patch fixing a commit, you should have the
> > author of that commit copied.  I added Viresh here.
> > 
> > It looks like a wrong fix to me.  It seems that commit b97872d4eb22
> > shouldn't change imx7d.dtsi at all.  So the correct fix would be
> > reverting the change on imx7d.dtsi, @Viresh?
> 
> Wow! Can't believe such a stupid mistake got merged and no one noticed
> :(
> 
> Please revert that patch and I will resend the right fix Shawn.

Please just send a incremental fix patch for that commit.

Shawn

[PATCH] ARM: dts: imx7d: add missing OPP property for cpu0

[Viresh Kumar]

On 19-07-18, 11:26, Shawn Guo wrote:
> On Thu, Jul 19, 2018 at 08:54:54AM +0530, Viresh Kumar wrote:
> > On 19-07-18, 11:20, Shawn Guo wrote:
> > > On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > > > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > > > added "operating-points" property for all CPUs, but missed i.MX7D's cpu0,
> > > > this patch adds it.
> > > > 
> > > > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for CPUs")
> > > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> > > 
> > > In general, when you send a patch fixing a commit, you should have the
> > > author of that commit copied.  I added Viresh here.
> > > 
> > > It looks like a wrong fix to me.  It seems that commit b97872d4eb22
> > > shouldn't change imx7d.dtsi at all.  So the correct fix would be
> > > reverting the change on imx7d.dtsi, @Viresh?
> > 
> > Wow! Can't believe such a stupid mistake got merged and no one noticed
> > :(
> > 
> > Please revert that patch and I will resend the right fix Shawn.
> 
> Please just send a incremental fix patch for that commit.

Sure. Actually I almost wrote the patch but then realized that it
wouldn't be fair for me to send a patch for something Anson has been
working on.

@Anson: Please send a patch to remove the "operating-points" property.

-- 
viresh

[PATCH] ARM: dts: imx7d: add missing OPP property for cpu0

[Anson Huang]

Hi, Shawn

Anson Huang
Best Regards!


> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo at kernel.org]
> Sent: Thursday, July 19, 2018 11:20 AM
> To: Anson Huang <anson.huang@nxp.com>; Viresh Kumar
> <viresh.kumar@linaro.org>
> Cc: s.hauer at pengutronix.de; kernel at pengutronix.de; Fabio Estevam
> <fabio.estevam@nxp.com>; robh+dt at kernel.org; mark.rutland at arm.com;
> linux-arm-kernel at lists.infradead.org; devicetree at vger.kernel.org;
> linux-kernel at vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>
> Subject: Re: [PATCH] ARM: dts: imx7d: add missing OPP property for cpu0
> 
> On Wed, Jul 18, 2018 at 02:54:49PM +0800, Anson Huang wrote:
> > Commit b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for
> > CPUs") added "operating-points" property for all CPUs, but missed
> > i.MX7D's cpu0, this patch adds it.
> >
> > Fixes: b97872d4eb22 ("ARM: dts: imx: Add missing OPP properties for
> > CPUs")
> > Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> 
> In general, when you send a patch fixing a commit, you should have the author
> of that commit copied.  I added Viresh here.

Thanks, I missed it.

> 
> It looks like a wrong fix to me.  It seems that commit b97872d4eb22 shouldn't
> change imx7d.dtsi at all.  So the correct fix would be reverting the change on
> imx7d.dtsi, @Viresh?

Agreed, I think the arch/arm/boot/dts/imx7d.dtsi should NOT be changed, as it already
had operating-points-v2 on both CPUs, I sent out another new patch with correct fix,
please review it.

Thanks.

Anson.


> 
> Shawn
> 
> > ---
> >  arch/arm/boot/dts/imx7d.dtsi | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx7d.dtsi
> > b/arch/arm/boot/dts/imx7d.dtsi index 9a772fc..30a1a73 100644
> > --- a/arch/arm/boot/dts/imx7d.dtsi
> > +++ b/arch/arm/boot/dts/imx7d.dtsi
> > @@ -9,6 +9,11 @@
> >  / {
> >  	cpus {
> >  		cpu0: cpu at 0 {
> > +			operating-points = <
> > +				/* KHz	uV */
> > +				996000	1075000
> > +				792000	975000
> > +			>;
> >  			clock-frequency = <996000000>;
> >  			operating-points-v2 = <&cpu0_opp_table>;
> >  			#cooling-cells = <2>;
> > --
> > 2.7.4
> >