From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: dts: imx7d: Add node for PCIe PHY
Date: Thu, 19 Jul 2018 11:24:43 +0800 [thread overview]
Message-ID: <20180719032442.GU4576@dragon> (raw)
In-Reply-To: <20180718194424.8844-2-tpiepho@impinj.com>
On Wed, Jul 18, 2018 at 12:44:23PM -0700, Trent Piepho wrote:
> There isn't yet any code in the kernel that uses this device's register,
> but there will be some for a PCIe PLL erratum wortkaround.
>
> This adds the PHY as a new node. The PCI-e controller node gains a
> phandle property that points to it. There is no driver for the PHY at
> this point and all the existing code that relates to the PHY is part of
> the PCI-e controller driver (and does not need register access, yet).
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Richard Zhu <hongxing.zhu@nxp.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Signed-off-by: Trent Piepho <tpiepho@impinj.com>
> ---
> Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 11 +++++++++++
> arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++
> 2 files changed, 20 insertions(+)
Please have separate patches for bindings and DTS.
Shawn
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> index cb33421184a0..c7aeda6878ff 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> @@ -50,6 +50,7 @@ Additional required properties for imx7d-pcie:
> - reset-names: Must contain the following entires:
> - "pciephy"
> - "apps"
> +- fsl,pcie-phy: A phandle to an fsl,imx-pcie-phy node.
>
> Example:
>
> @@ -76,3 +77,13 @@ Example:
> clocks = <&clks 144>, <&clks 206>, <&clks 189>;
> clock-names = "pcie", "pcie_bus", "pcie_phy";
> };
> +
> +* Freescale i.MX7d PCIe PHY
> +
> +This is the PHY associated with the IMX7d PCIe controller. It's used by the
> +PCI-e controller via the fsl,pcie-phy phandle.
> +
> +Required properties:
> +- compatible:
> + - "fsl,imx-pcie-phy"
> +- reg: base address and length of the PCIe PHY controller
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 200714e3feea..31f5c8576251 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -94,6 +94,14 @@
> };
> };
>
> +&aips2 {
> + pcie_phy: pcie-phy at 306d0000 {
> + compatible = "fsl,imx-pcie-phy";
> + reg = <0x306d0000 0x10000>;
> + status = "disabled";
> + };
> +};
> +
> &aips3 {
> usbotg2: usb at 30b20000 {
> compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> @@ -167,6 +175,7 @@
> <&src IMX7_RESET_PCIE_CTRL_APPS_EN>;
> reset-names = "pciephy", "apps";
> status = "disabled";
> + fsl,pcie-phy = <&pcie_phy>;
> };
> };
>
> --
> 2.14.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-07-19 3:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 19:44 [PATCH 0/2] Workaround for IMX7d PCI-e PLL lock failure Trent Piepho
2018-07-18 19:44 ` [PATCH 1/2] ARM: dts: imx7d: Add node for PCIe PHY Trent Piepho
2018-07-19 3:24 ` Shawn Guo [this message]
2018-08-01 10:39 ` Lucas Stach
2018-08-01 17:33 ` Trent Piepho
2018-08-02 0:43 ` Richard Zhu
2018-08-02 6:55 ` Lucas Stach
2018-07-18 19:44 ` [PATCH 2/2] PCI: imx: Add workaround for e10728, IMX7d PCIe PLL failure Trent Piepho
2018-08-01 10:44 ` Lucas Stach
2018-08-01 10:47 ` [PATCH 0/2] Workaround for IMX7d PCI-e PLL lock failure Lucas Stach
2018-09-17 10:13 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719032442.GU4576@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).