linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6: RDU2: fix irq type for mv88e6xxx switch
Date: Thu, 19 Jul 2018 22:53:58 +0200	[thread overview]
Message-ID: <20180719205358.GD12150@lunn.ch> (raw)
In-Reply-To: <20180719193823.9486-1-u.kleine-koenig@pengutronix.de>

On Thu, Jul 19, 2018 at 09:38:23PM +0200, Uwe Kleine-K?nig wrote:
> The Marvell switches report their interrupts in a level sensitive way.
> When using edge sensitive detection a race condition in the interrupt
> handler of the swich might result in the OS to miss all future events
> which might make the switch non-functional.
> 
> The problem is that both mv88e6xxx_g2_irq_thread_fn() and
> mv88e6xxx_g1_irq_thread_work() sample the irq cause register
> (MV88E6XXX_G2_INT_SRC and MV88E6XXX_G1_STS respectively) once and then
> handle the observed sources. If after sampling but before all observed
> irq sources are handled a new irq source gets active this is not noticed
> by the handler which returns unsuspecting, but the interrupt line stays
> active which prevents the edge detector to kick in.
> 
> All device trees but imx6qdl-zii-rdu2 get this right (most of them by
> not specifying an interrupt parent). So fix imx6qdl-zii-rdu2
> accordingly.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Fixes: f64992d1a916 ("ARM: dts: imx6: RDU2: Add Switch interrupts")

    Andrew

  parent reply	other threads:[~2018-07-19 20:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-19 19:38 [PATCH] ARM: dts: imx6: RDU2: fix irq type for mv88e6xxx switch Uwe Kleine-König
2018-07-19 19:42 ` Fabio Estevam
2018-07-19 20:53 ` Andrew Lunn [this message]
2018-07-20  2:51   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180719205358.GD12150@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).