From: cmaiolino28@gmail.com (Carlos Maiolino)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers
Date: Tue, 24 Jul 2018 10:32:17 +0200 [thread overview]
Message-ID: <20180724083217.20921-1-cmaiolino28@gmail.com> (raw)
Fix several sparse warnings regarding different address space
assignments, like example below, by properly annotating pointers
expected to carry user space addresses.
warning: incorrect type in argument 1 (different address spaces)
Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
---
I'm not subscribed to the list, so, please, CC me on any reply.
Thanks a lot.
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index bc05c69383b8..42f471471e57 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1648,8 +1648,8 @@ vchiq_compat_ioctl_queue_message(struct file *file,
unsigned int cmd,
unsigned long arg)
{
- VCHIQ_QUEUE_MESSAGE_T *args;
- struct vchiq_element *elements;
+ VCHIQ_QUEUE_MESSAGE_T __user *args;
+ struct vchiq_element __user *elements;
struct vchiq_queue_message32 args32;
unsigned int count;
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
index 9f859953f45c..1776fab41e40 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
@@ -50,7 +50,7 @@ typedef struct {
typedef struct {
unsigned int handle;
unsigned int count;
- const struct vchiq_element *elements;
+ const struct vchiq_element __user *elements;
} VCHIQ_QUEUE_MESSAGE_T;
typedef struct {
--
2.14.3
next reply other threads:[~2018-07-24 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 8:32 Carlos Maiolino [this message]
2018-07-30 8:58 ` [PATCH] staging/vc04_services: Use __user annotation for user-space pointers Greg KH
2018-07-30 9:08 ` Carlos Maiolino
2018-07-30 9:13 ` Stefan Wahren
2018-07-30 9:25 ` Carlos Maiolino
2018-07-30 9:34 ` Stefan Wahren
2018-07-30 9:43 ` Carlos Maiolino
2018-07-30 9:49 ` Stefan Wahren
2018-07-30 9:57 ` Carlos Maiolino
2018-08-03 16:05 ` Stefan Wahren
2018-07-30 9:14 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724083217.20921-1-cmaiolino28@gmail.com \
--to=cmaiolino28@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox