[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

Stefan Wahren
2018-07-30T09:13:23Z

Hi Carlos,

Am 30.07.2018 um 11:08 schrieb Carlos Maiolino:
> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH <greg@kroah.com> wrote:
>> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
>>> Fix several sparse warnings regarding different address space
>>> assignments, like example below, by properly annotating pointers
>>> expected to carry user space addresses.
>>>
>>> warning: incorrect type in argument 1 (different address spaces)
>>> Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
>>> ---
>> We need a blank line befor your signed-off-by line please.
>>
> Thanks, I'll resend, or do you prefer me to way until this get a review from
> the maintainer, and I resend the fixed description with the reviewed-by?

did you test your patch via vchiq_test or something else?

Please add Eric Anholt and fix my mail address in the second version, i
only received this via mailing list.

Stefan

>
>
>>> + const struct vchiq_element __user *elements;
>>> } VCHIQ_QUEUE_MESSAGE_T;
>>>
>>> typedef struct {
>> It would be great to have an ack from the maintainers here :)
>>
>> thanks,
>>
>> greg k-h
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel