linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: boris.brezillon@bootlin.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/10] drm/atomic: Add  __drm_atomic_helper_plane_reset
Date: Tue, 24 Jul 2018 10:16:56 +0200	[thread overview]
Message-ID: <20180724101656.0f472b0a@bbrezillon> (raw)
In-Reply-To: <20180724081402.GB22689@e114479-lin.cambridge.arm.com>

On Tue, 24 Jul 2018 09:14:02 +0100
Alexandru-Cosmin Gheorghe <Alexandru-Cosmin.Gheorghe@arm.com> wrote:

> On Tue, Jul 24, 2018 at 09:48:53AM +0200, Philipp Zabel wrote:
> > Hi Alexandru,
> > 
> > On Fri, 2018-07-20 at 22:15 +0100, Alexandru Gheorghe wrote:  
> > > There are a lot of drivers that subclass drm_plane_state, all of them
> > > duplicate the code that links toghether the plane with plane_state.
> > > 
> > > On top of that, drivers that enable core properties also have to
> > > duplicate the code for initializing the properties to their default
> > > values, which in all cases are the same as the defaults from core.
> > > 
> > > Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> > > ---
> > >  drivers/gpu/drm/drm_atomic_helper.c | 32 +++++++++++++++++++++--------
> > >  include/drm/drm_atomic_helper.h     |  2 ++
> > >  2 files changed, 25 insertions(+), 9 deletions(-)
> > > 
> > > diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c
> > > index 8008a7de2e10..e1c6f101652e 100644
> > > --- a/drivers/gpu/drm/drm_atomic_helper.c
> > > +++ b/drivers/gpu/drm/drm_atomic_helper.c
> > > @@ -3507,6 +3507,28 @@ void drm_atomic_helper_crtc_destroy_state(struct drm_crtc *crtc,
> > >  }
> > >  EXPORT_SYMBOL(drm_atomic_helper_crtc_destroy_state);
> > >  
> > > +/**
> > > + * __drm_atomic_helper_plane_reset - resets planes state to default values
> > > + * @plane: plane object
> > > + * @new_state: atomic plane state
> > > + *
> > > + * Initializes plane state to default. This is useful for drivers that subclass
> > > + * the plane state.
> > > + */
> > > +void __drm_atomic_helper_plane_reset(struct drm_plane *plane,
> > > +				     struct drm_plane_state *state)
> > > +{
> > > +	if (state) {
> > > +		state->plane = plane;
> > > +		state->rotation = DRM_MODE_ROTATE_0;
> > > +		/* Reset the alpha value to fully opaque if it matters */
> > > +		if (plane->alpha_property)
> > > +			state->alpha = plane->alpha_property->values[1];
> > > +	}  
> > 
> > Is this function supposed to be callable with state == NULL ?
> >   
> > > +	plane->state = state;  
> > 
> > If so, the comment could mention that this sets plane->state to NULL if
> > state == NULL, and a few of the call sites could be simplified.
> > 
> > If not, I would remove the conditional if (state) {} part and also
> > mention this in the comment.  
> 
> Yes, It's intended to be callable with null.

May I ask why? I'd assume drivers that call this function to pass a
non-NULL plane state. What's the use case for passing a NULL state here?

  reply	other threads:[~2018-07-24  8:16 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180713161407.GQ20303@art_vandelay>
2018-07-20 21:14 ` [PATCH 00/10] Add helper for plane reset Alexandru Gheorghe
2018-07-20 21:15   ` [PATCH 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset Alexandru Gheorghe
2018-07-23  9:37     ` Ayan Halder
2018-07-24  7:48     ` Philipp Zabel
2018-07-24  8:14       ` Alexandru-Cosmin Gheorghe
2018-07-24  8:16         ` Boris Brezillon [this message]
2018-07-24  9:28           ` Alexandru-Cosmin Gheorghe
2018-07-20 21:15   ` [PATCH 02/10] drm/amd/display: Use __drm_atomic_helper_plane_reset instead of copying the logic Alexandru Gheorghe
2018-07-20 21:15   ` [PATCH 03/10] drm: mali-dp: " Alexandru Gheorghe
2018-07-23  9:35     ` Ayan Halder
2018-07-24  8:26     ` Liviu Dudau
2018-07-20 21:15   ` [PATCH 04/10] drm: atmel-hlcdc: " Alexandru Gheorghe
2018-07-21  6:12     ` Boris Brezillon
2018-07-20 21:15   ` [PATCH 05/10] drm/exynos: " Alexandru Gheorghe
2018-07-20 21:15   ` [PATCH 06/10] drm/imx: " Alexandru Gheorghe
2018-07-24  7:49     ` Philipp Zabel
2018-07-24  7:51       ` Philipp Zabel
2018-07-20 21:15   ` [PATCH 07/10] drm: rcar-du: " Alexandru Gheorghe
2018-07-20 21:15   ` [PATCH 08/10] drm/sun4i: " Alexandru Gheorghe
2018-07-20 21:15   ` [PATCH 09/10] drm/vc4: " Alexandru Gheorghe
2018-07-24  6:57     ` Maxime Ripard
2018-07-24  8:11       ` Alexandru-Cosmin Gheorghe
2018-07-24 12:54         ` Maxime Ripard
2018-07-20 21:15   ` [PATCH 10/10] drm/vmwgfx: " Alexandru Gheorghe
2018-07-23 17:16     ` Deepak Singh Rawat
2018-07-23 18:02     ` Sinclair Yeh
2018-07-24 15:31   ` [PATCH 00/10] Add helper for plane reset Harry Wentland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724101656.0f472b0a@bbrezillon \
    --to=boris.brezillon@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).