linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: maxime.ripard@bootlin.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5
Date: Tue, 24 Jul 2018 15:00:04 +0200	[thread overview]
Message-ID: <20180724130004.ynaiabshexrrbvo4@flea> (raw)
In-Reply-To: <20180724101522.68165-5-manu@freebsd.org>

On Tue, Jul 24, 2018 at 12:15:22PM +0200, Emmanuel Vadot wrote:
> The SID controller on H5 look the same as the one present in the A64.
> But in case we find some difference one day at a compatible string
> of it's own and a fallback to the A64 one.
> 
> Signed-off-by: Emmanuel Vadot <manu@freebsd.org>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> index 62d646baac3c..28183bf77164 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5.dtsi
> @@ -129,3 +129,8 @@
>  		     <GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>;
>  	compatible = "allwinner,sun50i-h5-pinctrl";
>  };
> +
> +&sid {
> +	compatible = "allwinner,sun50i-h5-sid",
> +		     "allwinner,sun50i-a64-sid";
> +};

This is still a bit pointless, please remove the common node.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180724/b4713889/attachment.sig>

  reply	other threads:[~2018-07-24 13:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 10:15 [PATCH v2 1/5] arm64: dts: allwinner: a64: Add SID node Emmanuel Vadot
2018-07-24 10:15 ` [PATCH v2 2/5] ARM: dts: sunxi: h3/h5: " Emmanuel Vadot
2018-07-24 10:15 ` [PATCH v2 3/5] ARM: dts: sun8i: h3: Add SID compatible string Emmanuel Vadot
2018-07-24 10:15 ` [PATCH v2 4/5] nvmem: sunxi-sid: add support for H5's SID controller Emmanuel Vadot
2018-07-24 13:00   ` Maxime Ripard
2018-07-24 10:15 ` [PATCH v2 5/5] arm64: dts: allwinner: h5: Add SID for H5 Emmanuel Vadot
2018-07-24 13:00   ` Maxime Ripard [this message]
2018-07-24 13:34     ` Emmanuel Vadot
2018-07-24 14:42       ` Maxime Ripard
2018-07-24 14:55         ` Emmanuel Vadot
2018-07-26 11:54           ` Maxime Ripard
2018-07-27 10:56             ` Emmanuel Vadot
2018-07-27 11:34               ` Emmanuel Vadot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724130004.ynaiabshexrrbvo4@flea \
    --to=maxime.ripard@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).