From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: enable RapidIO config options in Kconfig
Date: Tue, 24 Jul 2018 16:14:59 +0100 [thread overview]
Message-ID: <20180724151458.GE25412@arm.com> (raw)
In-Reply-To: <20180724134513.86796-1-acolin@isi.edu>
On Tue, Jul 24, 2018 at 09:45:14AM -0400, Alexei Colin wrote:
> ARM64 SoCs with a PCI bus present the RapiodIO options; SoCs with
> RapidIO IP blocks but without a PCI bus, need to select HAS_RAPIDIO in
> Kconfig.platforms.
>
> HAS_RAPIDIO was chosen over HAVE_RAPIDIO to be consistent with
> other architectures which already define this flag (powerpc).
>
> Signed-off-by: Alexei Colin <acolin@isi.edu>
> ---
>
> Tested that kernel builds with RapidIO subsystem and switch drivers and that
> modules insert successfully in a custom Qemu hardware model.
> Maintainers for RapidIO subsystem CCed.
> Similar patch for ARM has been submitted.
>
> arch/arm64/Kconfig | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 42c090cf0292..8dceaa5b674c 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -293,6 +293,22 @@ config PCI_SYSCALL
>
> source "drivers/pci/Kconfig"
>
> +config HAS_RAPIDIO
> + bool
> + default n
> +
> +config RAPIDIO
> + tristate "RapidIO support"
> + depends on HAS_RAPIDIO || PCI
> + help
> + This feature enables support for RapidIO high-performance
> + packet-switched interconnect.
> +
> + If you say Y here, the kernel will include drivers and
> + infrastructure code to support RapidIO interconnect devices.
It feels a bit weird to push this help text into the arch Kconfig files,
rather than just have them provide the HAS_RAPIDIO symbol, but if that's
what everybody else is doing then I guess it's fine.
Will
next prev parent reply other threads:[~2018-07-24 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 13:45 [PATCH] arm64: enable RapidIO config options in Kconfig Alexei Colin
2018-07-24 15:14 ` Will Deacon [this message]
2018-07-24 16:49 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724151458.GE25412@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).