linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] arm64: mm: Export __sync_icache_dcache() for xen-privcmd
Date: Fri, 27 Jul 2018 14:22:44 +0100	[thread overview]
Message-ID: <20180727132243.GA28549@arm.com> (raw)
In-Reply-To: <20180727120633.bjpfqswuxcy2ibqu@armageddon.cambridge.arm.com>

On Fri, Jul 27, 2018 at 01:06:33PM +0100, Catalin Marinas wrote:
> On Thu, Jul 12, 2018 at 12:18:22AM +0100, Ben Hutchings wrote:
> > The xen-privcmd driver, which can be modular, calls set_pte_at()
> > which in turn may call __sync_icache_dcache().
> > 
> > The call to __sync_icache_dcache() may be optimised out because it is
> > conditional on !pte_special(), and xen-privcmd calls pte_mkspecial().
> > But it seems unwise to rely on this optimisation.
> > 
> > Fixes: 3ad0876554ca ("xen/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE")
> > Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
> > ---
> > This is an RFC since I haven't found an actual build failure.  Using
> > Debian's gcc 7.3 with either CC_OPTIMIZE_FOR_PERFORMANCE or
> > CC_OPTIMIZE_FOR_SIZE, the call *is* optimised away.
> 
> Since apply_to_page_range() is EXPORT_SYMBOL_GPL() and a
> pte_fn_t function would likely use set_pte_at(), I'm fine with this
> patch for consistency.
> 
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>

Okey doke, I'll pick this up for 4.19.

Will

  reply	other threads:[~2018-07-27 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-11 23:18 [RFC PATCH] arm64: mm: Export __sync_icache_dcache() for xen-privcmd Ben Hutchings
2018-07-27 12:06 ` Catalin Marinas
2018-07-27 13:22   ` Will Deacon [this message]
2018-07-30  6:46     ` Geert Uytterhoeven
2018-07-30  6:50       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727132243.GA28549@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).