From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair
Date: Sat, 28 Jul 2018 19:08:09 -0700 (PDT) [thread overview]
Message-ID: <20180728.190809.1376213313357548269.davem@davemloft.net> (raw)
In-Reply-To: <20180727161707.GP10686@lunn.ch>
From: Andrew Lunn <andrew@lunn.ch>
Date: Fri, 27 Jul 2018 18:17:07 +0200
> On Fri, Jul 27, 2018 at 06:57:47PM +0300, Anton Vasilyev wrote:
>> mdio_mux_iproc_probe() uses platform_set_drvdata() to store md pointer
>> in device, whereas mdio_mux_iproc_remove() restores md pointer by
>> dev_get_platdata(&pdev->dev). This leads to wrong resources release.
>>
>> The patch replaces getter to platform_get_drvdata.
>>
>> Signed-off-by: Anton Vasilyev <vasilyev@ispras.ru>
>
> Fixes: 98bc865a1ec8 ("net: mdio-mux: Add MDIO mux driver for iProc SoCs")
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2018-07-29 2:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 15:57 [PATCH] net: mdio-mux: bcm-iproc: fix wrong getter and setter pair Anton Vasilyev
2018-07-27 16:17 ` Andrew Lunn
2018-07-29 2:08 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180728.190809.1376213313357548269.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).