[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Carlos Maiolino]

Fix several sparse warnings regarding different address space
assignments, like example below, by properly annotating pointers
expected to carry user space addresses.

warning: incorrect type in argument 1 (different address spaces)
Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
---

I'm not subscribed to the list, so, please, CC me on any reply.
Thanks a lot.

 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c   | 4 ++--
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index bc05c69383b8..42f471471e57 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1648,8 +1648,8 @@ vchiq_compat_ioctl_queue_message(struct file *file,
 				 unsigned int cmd,
 				 unsigned long arg)
 {
-	VCHIQ_QUEUE_MESSAGE_T *args;
-	struct vchiq_element *elements;
+	VCHIQ_QUEUE_MESSAGE_T __user *args;
+	struct vchiq_element __user *elements;
 	struct vchiq_queue_message32 args32;
 	unsigned int count;
 
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
index 9f859953f45c..1776fab41e40 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
@@ -50,7 +50,7 @@ typedef struct {
 typedef struct {
 	unsigned int handle;
 	unsigned int count;
-	const struct vchiq_element *elements;
+	const struct vchiq_element __user *elements;
 } VCHIQ_QUEUE_MESSAGE_T;
 
 typedef struct {
-- 
2.14.3

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Greg KH]

On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
> Fix several sparse warnings regarding different address space
> assignments, like example below, by properly annotating pointers
> expected to carry user space addresses.
> 
> warning: incorrect type in argument 1 (different address spaces)
> Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
> ---

We need a blank line befor your signed-off-by line please.

> I'm not subscribed to the list, so, please, CC me on any reply.
> Thanks a lot.
> 
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c   | 4 ++--
>  drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index bc05c69383b8..42f471471e57 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -1648,8 +1648,8 @@ vchiq_compat_ioctl_queue_message(struct file *file,
>  				 unsigned int cmd,
>  				 unsigned long arg)
>  {
> -	VCHIQ_QUEUE_MESSAGE_T *args;
> -	struct vchiq_element *elements;
> +	VCHIQ_QUEUE_MESSAGE_T __user *args;
> +	struct vchiq_element __user *elements;
>  	struct vchiq_queue_message32 args32;
>  	unsigned int count;
>  
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
> index 9f859953f45c..1776fab41e40 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_ioctl.h
> @@ -50,7 +50,7 @@ typedef struct {
>  typedef struct {
>  	unsigned int handle;
>  	unsigned int count;
> -	const struct vchiq_element *elements;
> +	const struct vchiq_element __user *elements;
>  } VCHIQ_QUEUE_MESSAGE_T;
>  
>  typedef struct {

It would be great to have an ack from the maintainers here :)

thanks,

greg k-h

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Carlos Maiolino]

On Mon, Jul 30, 2018 at 10:58 AM, Greg KH <greg@kroah.com> wrote:
> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
>> Fix several sparse warnings regarding different address space
>> assignments, like example below, by properly annotating pointers
>> expected to carry user space addresses.
>>
>> warning: incorrect type in argument 1 (different address spaces)
>> Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
>> ---
>
> We need a blank line befor your signed-off-by line please.
>

Thanks, I'll resend, or do you prefer me to way until this get a review from
the maintainer, and I resend the fixed description with the reviewed-by?


>> +     const struct vchiq_element __user *elements;
>>  } VCHIQ_QUEUE_MESSAGE_T;
>>
>>  typedef struct {
>
> It would be great to have an ack from the maintainers here :)
>
> thanks,
>
> greg k-h

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Stefan Wahren]

Hi Carlos,


Am 30.07.2018 um 11:08 schrieb Carlos Maiolino:
> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH <greg@kroah.com> wrote:
>> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
>>> Fix several sparse warnings regarding different address space
>>> assignments, like example below, by properly annotating pointers
>>> expected to carry user space addresses.
>>>
>>> warning: incorrect type in argument 1 (different address spaces)
>>> Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
>>> ---
>> We need a blank line befor your signed-off-by line please.
>>
> Thanks, I'll resend, or do you prefer me to way until this get a review from
> the maintainer, and I resend the fixed description with the reviewed-by?

did you test your patch via vchiq_test or something else?

Please add Eric Anholt and fix my mail address in the second version, i 
only received this via mailing list.

Stefan

>
>
>>> +     const struct vchiq_element __user *elements;
>>>   } VCHIQ_QUEUE_MESSAGE_T;
>>>
>>>   typedef struct {
>> It would be great to have an ack from the maintainers here :)
>>
>> thanks,
>>
>> greg k-h
> _______________________________________________
> linux-rpi-kernel mailing list
> linux-rpi-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Greg KH]

On Mon, Jul 30, 2018 at 11:08:06AM +0200, Carlos Maiolino wrote:
> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH <greg@kroah.com> wrote:
> > On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
> >> Fix several sparse warnings regarding different address space
> >> assignments, like example below, by properly annotating pointers
> >> expected to carry user space addresses.
> >>
> >> warning: incorrect type in argument 1 (different address spaces)
> >> Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
> >> ---
> >
> > We need a blank line befor your signed-off-by line please.
> >
> 
> Thanks, I'll resend, or do you prefer me to way until this get a review from
> the maintainer, and I resend the fixed description with the reviewed-by?

I should never have to hand-edit a patch, otherwise maintainers will not
scale, so yes, I need a new version.  But it would be great if we got a
review from the proper maintainers first so you know if anything else
needs to be done.

thanks,

greg k-h

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Carlos Maiolino]

On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi Carlos,
>
>
> Am 30.07.2018 um 11:08 schrieb Carlos Maiolino:
>>
>> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH <greg@kroah.com> wrote:
>>>
>>> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
>>>>
>>>> Fix several sparse warnings regarding different address space
>>>> assignments, like example below, by properly annotating pointers
>>>> expected to carry user space addresses.
>>>>
>>>> warning: incorrect type in argument 1 (different address spaces)
>>>> Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
>>>> ---
>>>
>>> We need a blank line befor your signed-off-by line please.
>>>
>> Thanks, I'll resend, or do you prefer me to way until this get a review
>> from
>> the maintainer, and I resend the fixed description with the reviewed-by?
>
>
> did you test your patch via vchiq_test or something else?
>

Hi, no. Can you please point me where I can get it?


> Please add Eric Anholt

Sure, will do

>and fix my mail address in the second version, i only
> received this via mailing list.
>

Meh, I shall use copy/paste next time :P
> Stefan
>
>>
>>
>>>> +     const struct vchiq_element __user *elements;
>>>>   } VCHIQ_QUEUE_MESSAGE_T;
>>>>
>>>>   typedef struct {
>>>
>>> It would be great to have an ack from the maintainers here :)
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> _______________________________________________
>> linux-rpi-kernel mailing list
>> linux-rpi-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel
>
>

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Stefan Wahren]

Hi Carlos,

Am 30.07.2018 um 11:25 schrieb Carlos Maiolino:
> On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>> Hi Carlos,
>>
>>
>> Am 30.07.2018 um 11:08 schrieb Carlos Maiolino:
>>> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH <greg@kroah.com> wrote:
>>>> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
>>>>> Fix several sparse warnings regarding different address space
>>>>> assignments, like example below, by properly annotating pointers
>>>>> expected to carry user space addresses.
>>>>>
>>>>> warning: incorrect type in argument 1 (different address spaces)
>>>>> Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
>>>>> ---
>>>> We need a blank line befor your signed-off-by line please.
>>>>
>>> Thanks, I'll resend, or do you prefer me to way until this get a review
>>> from
>>> the maintainer, and I resend the fixed description with the reviewed-by?
>>
>> did you test your patch via vchiq_test or something else?
>>
> Hi, no. Can you please point me where I can get it?
>
>

i think easiest the way would be to get a recent Raspbian Lite ( 
https://www.raspberrypi.org/downloads/raspbian/ ),
build the kernel with bcm2835_defconfig, modify config.txt to use the 
upstream DTB, add the upstream kernel and DTB to boot partition.

The following command must be successful:

vchiq_test -f 1

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Carlos Maiolino]

On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Hi Carlos,
>
> Am 30.07.2018 um 11:25 schrieb Carlos Maiolino:
>>
>> On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren <stefan.wahren@i2se.com>
>> wrote:
>>>
>>> Hi Carlos,
>>>
>>>
>>> Am 30.07.2018 um 11:08 schrieb Carlos Maiolino:
>>>>
>>>> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH <greg@kroah.com> wrote:
>>>>>
>>>>> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
>>>>>>
>>>>>> Fix several sparse warnings regarding different address space
>>>>>> assignments, like example below, by properly annotating pointers
>>>>>> expected to carry user space addresses.
>>>>>>
>>>>>> warning: incorrect type in argument 1 (different address spaces)
>>>>>> Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
>>>>>> ---
>>>>>
>>>>> We need a blank line befor your signed-off-by line please.
>>>>>
>>>> Thanks, I'll resend, or do you prefer me to way until this get a review
>>>> from
>>>> the maintainer, and I resend the fixed description with the reviewed-by?
>>>
>>>
>>> did you test your patch via vchiq_test or something else?
>>>
>> Hi, no. Can you please point me where I can get it?
>>
>>
>
> i think easiest the way would be to get a recent Raspbian Lite (
> https://www.raspberrypi.org/downloads/raspbian/ ),
> build the kernel with bcm2835_defconfig, modify config.txt to use the
> upstream DTB, add the upstream kernel and DTB to boot partition.
>
> The following command must be successful:
>
> vchiq_test -f 1

K, I'll take a look and find a way to test it, I don't have a rPI at
the moment to test
it, I'll take a look if I can borrow one. in mean time, can it be
tested somehow in x86 environment?

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Stefan Wahren]

Am 30.07.2018 um 11:43 schrieb Carlos Maiolino:
> On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>> i think easiest the way would be to get a recent Raspbian Lite (
>> https://www.raspberrypi.org/downloads/raspbian/ ),
>> build the kernel with bcm2835_defconfig, modify config.txt to use the
>> upstream DTB, add the upstream kernel and DTB to boot partition.
>>
>> The following command must be successful:
>>
>> vchiq_test -f 1
> K, I'll take a look and find a way to test it, I don't have a rPI at
> the moment to test
> it, I'll take a look if I can borrow one. in mean time, can it be
> tested somehow in x86 environment?

I don't see a chance because this driver talks to the VC4 firmware.

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Carlos Maiolino]

On Mon, Jul 30, 2018 at 11:49 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Am 30.07.2018 um 11:43 schrieb Carlos Maiolino:
>> On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
>>> i think easiest the way would be to get a recent Raspbian Lite (
>>> https://www.raspberrypi.org/downloads/raspbian/ ),
>>> build the kernel with bcm2835_defconfig, modify config.txt to use the
>>> upstream DTB, add the upstream kernel and DTB to boot partition.
>>>
>>> The following command must be successful:
>>>
>>> vchiq_test -f 1
>> K, I'll take a look and find a way to test it, I don't have a rPI at
>> the moment to test
>> it, I'll take a look if I can borrow one. in mean time, can it be
>> tested somehow in x86 environment?
>
> I don't see a chance because this driver talks to the VC4 firmware.
>

kk

thx

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

[Stefan Wahren]

Hi Carlos,

> Carlos Maiolino <cmaiolino28@gmail.com> hat am 30. Juli 2018 um 11:57 geschrieben:
> 
> 
> On Mon, Jul 30, 2018 at 11:49 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> > Am 30.07.2018 um 11:43 schrieb Carlos Maiolino:
> >> On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> >>> i think easiest the way would be to get a recent Raspbian Lite (
> >>> https://www.raspberrypi.org/downloads/raspbian/ ),
> >>> build the kernel with bcm2835_defconfig, modify config.txt to use the
> >>> upstream DTB, add the upstream kernel and DTB to boot partition.
> >>>
> >>> The following command must be successful:
> >>>
> >>> vchiq_test -f 1
> >> K, I'll take a look and find a way to test it, I don't have a rPI at
> >> the moment to test
> >> it, I'll take a look if I can borrow one. in mean time, can it be
> >> tested somehow in x86 environment?
> >
> > I don't see a chance because this driver talks to the VC4 firmware.
> >
> 
> kk
> 
> thx

i only want to point out that there was a regression (deadlock) in linux-next, which has been reverted [1] / fixed.

[1] - https://lkml.org/lkml/2018/8/2/578