From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers
Date: Mon, 30 Jul 2018 11:14:11 +0200 [thread overview]
Message-ID: <20180730091411.GA31261@kroah.com> (raw)
In-Reply-To: <CAGR7KeoDrp8FBX_H1a8h9hVFF_w9mLXGkvCT6jJAacG7-morRg@mail.gmail.com>
On Mon, Jul 30, 2018 at 11:08:06AM +0200, Carlos Maiolino wrote:
> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH <greg@kroah.com> wrote:
> > On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote:
> >> Fix several sparse warnings regarding different address space
> >> assignments, like example below, by properly annotating pointers
> >> expected to carry user space addresses.
> >>
> >> warning: incorrect type in argument 1 (different address spaces)
> >> Signed-off-by: Carlos Maiolino <cmaiolino28@gmail.com>
> >> ---
> >
> > We need a blank line befor your signed-off-by line please.
> >
>
> Thanks, I'll resend, or do you prefer me to way until this get a review from
> the maintainer, and I resend the fixed description with the reviewed-by?
I should never have to hand-edit a patch, otherwise maintainers will not
scale, so yes, I need a new version. But it would be great if we got a
review from the proper maintainers first so you know if anything else
needs to be done.
thanks,
greg k-h
prev parent reply other threads:[~2018-07-30 9:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 8:32 [PATCH] staging/vc04_services: Use __user annotation for user-space pointers Carlos Maiolino
2018-07-30 8:58 ` Greg KH
2018-07-30 9:08 ` Carlos Maiolino
2018-07-30 9:13 ` Stefan Wahren
2018-07-30 9:25 ` Carlos Maiolino
2018-07-30 9:34 ` Stefan Wahren
2018-07-30 9:43 ` Carlos Maiolino
2018-07-30 9:49 ` Stefan Wahren
2018-07-30 9:57 ` Carlos Maiolino
2018-08-03 16:05 ` Stefan Wahren
2018-07-30 9:14 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730091411.GA31261@kroah.com \
--to=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox