From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] regulator: rk808: add RK809 and RK817 support.
Date: Wed, 1 Aug 2018 10:25:12 +0100 [thread overview]
Message-ID: <20180801092512.GA5509@sirena.org.uk> (raw)
In-Reply-To: <1533023850-29004-3-git-send-email-tony.xie@rock-chips.com>
On Tue, Jul 31, 2018 at 03:57:27PM +0800, Tony Xie wrote:
> + default:
> + pr_warn("%s ramp_delay: %d not supported, setting 10000\n",
> + rdev->desc->name, ramp_delay);
> + }
This looks mostly good but I notice that most of the prints in the
driver are pr_ rather than dev_ ones - using dev_ is better as it allows
people to see which device was affected.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180801/de3716a8/attachment-0001.sig>
next prev parent reply other threads:[~2018-08-01 9:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-31 7:57 [PATCH v2 0/5] support a new type of PMIC，including two chips(rk817 and rk809) Tony Xie
2018-07-31 7:57 ` [PATCH v2 1/5] mfd: rk808: Add RK817 and RK809 support Tony Xie
2018-07-31 7:57 ` [PATCH v2 2/5] regulator: rk808: add RK809 and RK817 support Tony Xie
2018-08-01 9:25 ` Mark Brown [this message]
2018-07-31 7:57 ` [PATCH v2 3/5] dt-bindings: mfd: rk808: Add binding informations for RK809 and RK817 Tony Xie
2018-08-02 11:16 ` Heiko Stuebner
2018-07-31 7:57 ` [PATCH v2 4/5] RTC: RK808: add RK809 and RK817 support Tony Xie
2018-07-31 8:10 ` Alexandre Belloni
2018-07-31 8:00 ` [PATCH v2 5/5] clk: " Tony Xie
2018-08-01 15:18 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801092512.GA5509@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).