From: syeh@vmware.com (Sinclair Yeh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 10/10] drm/vmwgfx: Use __drm_atomic_helper_plane_reset instead of copying the logic
Date: Mon, 6 Aug 2018 09:57:53 -0700 [thread overview]
Message-ID: <20180806165752.GD17089@vmware.com> (raw)
In-Reply-To: <20180804161530.12275-11-alexandru-cosmin.gheorghe@arm.com>
Acked-by: Sinclair Yeh <syeh@vmware.com>
On Sat, Aug 04, 2018 at 05:15:30PM +0100, Alexandru Gheorghe wrote:
> A new helper function(__drm_atomic_helper_plane_reset) has been added
> for linking a plane with its state and resetting the core
> properties(alpha, rotation, etc.) to their default values.
> Use that instead of duplicating the logic.
>
> Reviewed-by: Sinclair Yeh <syeh@vmware.com>
> Reviewed-by: Deepak Rawat <drawat@vmware.com>
> Signed-off-by: Alexandru Gheorghe <alexandru-cosmin.gheorghe@arm.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> index 4a0f0f41afa1..61824e360619 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c
> @@ -720,9 +720,7 @@ void vmw_du_plane_reset(struct drm_plane *plane)
> return;
> }
>
> - plane->state = &vps->base;
> - plane->state->plane = plane;
> - plane->state->rotation = DRM_MODE_ROTATE_0;
> + __drm_atomic_helper_plane_reset(plane, &vps->base);
> }
>
>
> --
> 2.18.0
>
next prev parent reply other threads:[~2018-08-06 16:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 16:15 [PATCH v3 00/10] Add helper for plane reset Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 01/10] drm/atomic: Add __drm_atomic_helper_plane_reset Alexandru Gheorghe
2018-08-06 6:29 ` Philipp Zabel
2018-08-04 16:15 ` [PATCH v3 02/10] drm/amd/display: Use __drm_atomic_helper_plane_reset instead of copying the logic Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 03/10] drm: mali-dp: " Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 04/10] drm: atmel-hlcdc: " Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 05/10] drm/exynos: " Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 06/10] drm/imx: " Alexandru Gheorghe
2018-08-06 6:29 ` Philipp Zabel
2018-08-06 8:53 ` Alexandru-Cosmin Gheorghe
2018-08-04 16:15 ` [PATCH v3 07/10] drm: rcar-du: " Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 08/10] drm/sun4i: " Alexandru Gheorghe
2018-08-04 16:15 ` [PATCH v3 09/10] drm/vc4: " Alexandru Gheorghe
2018-08-06 19:58 ` Eric Anholt
2018-08-04 16:15 ` [PATCH v3 10/10] drm/vmwgfx: " Alexandru Gheorghe
2018-08-06 16:57 ` Sinclair Yeh [this message]
2018-08-07 8:03 ` Alexandru-Cosmin Gheorghe
2018-08-07 13:25 ` Sinclair Yeh
2018-08-06 11:07 ` [PATCH v3 00/10] Add helper for plane reset Alexandru-Cosmin Gheorghe
2018-08-06 11:45 ` Laurent Pinchart
2018-08-06 12:20 ` Alexandru-Cosmin Gheorghe
2018-08-06 12:28 ` Laurent Pinchart
2018-08-06 15:48 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180806165752.GD17089@vmware.com \
--to=syeh@vmware.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).