* [PATCH] remoteproc/davinci: Mark error recovery as disabled
@ 2018-07-23 23:27 Suman Anna
2018-08-13 15:11 ` Suman Anna
0 siblings, 1 reply; 4+ messages in thread
From: Suman Anna @ 2018-07-23 23:27 UTC (permalink / raw)
To: linux-arm-kernel
The Davinci remoteproc driver does not support error recovery at
present, so mark the corresponding remoteproc flag appropriately
so that the debugfs flag shows the value as 'disabled' by default.
Signed-off-by: Suman Anna <s-anna@ti.com>
---
drivers/remoteproc/da8xx_remoteproc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
index b668e32996e2..53160d5ed543 100644
--- a/drivers/remoteproc/da8xx_remoteproc.c
+++ b/drivers/remoteproc/da8xx_remoteproc.c
@@ -284,6 +284,9 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
goto free_mem;
}
+ /* error recovery is not supported at present */
+ rproc->recovery_disabled = true;
+
drproc = rproc->priv;
drproc->rproc = rproc;
drproc->dsp_clk = dsp_clk;
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] remoteproc/davinci: Mark error recovery as disabled
2018-07-23 23:27 [PATCH] remoteproc/davinci: Mark error recovery as disabled Suman Anna
@ 2018-08-13 15:11 ` Suman Anna
2018-08-13 18:52 ` Bjorn Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Suman Anna @ 2018-08-13 15:11 UTC (permalink / raw)
To: linux-arm-kernel
Hi Bjorn,
On 07/23/2018 06:27 PM, Suman Anna wrote:
> The Davinci remoteproc driver does not support error recovery at
> present, so mark the corresponding remoteproc flag appropriately
> so that the debugfs flag shows the value as 'disabled' by default.
>
> Signed-off-by: Suman Anna <s-anna@ti.com>
Can you pick up this minor patch for 4.19 please, I do not see this in
your rproc-next branch?
Thanks,
Suman
> ---
> drivers/remoteproc/da8xx_remoteproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> index b668e32996e2..53160d5ed543 100644
> --- a/drivers/remoteproc/da8xx_remoteproc.c
> +++ b/drivers/remoteproc/da8xx_remoteproc.c
> @@ -284,6 +284,9 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
> goto free_mem;
> }
>
> + /* error recovery is not supported at present */
> + rproc->recovery_disabled = true;
> +
> drproc = rproc->priv;
> drproc->rproc = rproc;
> drproc->dsp_clk = dsp_clk;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] remoteproc/davinci: Mark error recovery as disabled
2018-08-13 15:11 ` Suman Anna
@ 2018-08-13 18:52 ` Bjorn Andersson
2018-08-14 5:20 ` Sekhar Nori
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2018-08-13 18:52 UTC (permalink / raw)
To: linux-arm-kernel
On Mon 13 Aug 08:11 PDT 2018, Suman Anna wrote:
> Hi Bjorn,
>
> On 07/23/2018 06:27 PM, Suman Anna wrote:
> > The Davinci remoteproc driver does not support error recovery at
> > present, so mark the corresponding remoteproc flag appropriately
> > so that the debugfs flag shows the value as 'disabled' by default.
> >
> > Signed-off-by: Suman Anna <s-anna@ti.com>
>
> Can you pick up this minor patch for 4.19 please, I do not see this in
> your rproc-next branch?
>
Of course, the patch is applied now, will send my pull request in a few
days.
Regards,
Bjorn
> Thanks,
> Suman
>
> > ---
> > drivers/remoteproc/da8xx_remoteproc.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/remoteproc/da8xx_remoteproc.c b/drivers/remoteproc/da8xx_remoteproc.c
> > index b668e32996e2..53160d5ed543 100644
> > --- a/drivers/remoteproc/da8xx_remoteproc.c
> > +++ b/drivers/remoteproc/da8xx_remoteproc.c
> > @@ -284,6 +284,9 @@ static int da8xx_rproc_probe(struct platform_device *pdev)
> > goto free_mem;
> > }
> >
> > + /* error recovery is not supported at present */
> > + rproc->recovery_disabled = true;
> > +
> > drproc = rproc->priv;
> > drproc->rproc = rproc;
> > drproc->dsp_clk = dsp_clk;
> >
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] remoteproc/davinci: Mark error recovery as disabled
2018-08-13 18:52 ` Bjorn Andersson
@ 2018-08-14 5:20 ` Sekhar Nori
0 siblings, 0 replies; 4+ messages in thread
From: Sekhar Nori @ 2018-08-14 5:20 UTC (permalink / raw)
To: linux-arm-kernel
Hi Bjorn,
On Tuesday 14 August 2018 12:22 AM, Bjorn Andersson wrote:
> On Mon 13 Aug 08:11 PDT 2018, Suman Anna wrote:
>
>> Hi Bjorn,
>>
>> On 07/23/2018 06:27 PM, Suman Anna wrote:
>>> The Davinci remoteproc driver does not support error recovery at
>>> present, so mark the corresponding remoteproc flag appropriately
>>> so that the debugfs flag shows the value as 'disabled' by default.
>>>
>>> Signed-off-by: Suman Anna <s-anna@ti.com>
>>
>> Can you pick up this minor patch for 4.19 please, I do not see this in
>> your rproc-next branch?
>>
>
> Of course, the patch is applied now, will send my pull request in a few
> days.
Can you also please pick patch 1/4 here:
https://patchwork.kernel.org/patch/10479365/
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-14 5:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-23 23:27 [PATCH] remoteproc/davinci: Mark error recovery as disabled Suman Anna
2018-08-13 15:11 ` Suman Anna
2018-08-13 18:52 ` Bjorn Andersson
2018-08-14 5:20 ` Sekhar Nori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).