linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/7] perf: Add ioctl for PMU driver configuration
Date: Wed, 15 Aug 2018 10:39:13 +0100	[thread overview]
Message-ID: <20180815093912.GE2427@arm.com> (raw)
In-Reply-To: <CANLsYkxZ_Wts6k9yqJhJf_R5oh74svpcuoNxhtFf6h3mz8U4ZA@mail.gmail.com>

On Tue, Aug 14, 2018 at 01:42:27PM -0600, Mathieu Poirier wrote:
> On Tue, 14 Aug 2018 at 11:09, Kim Phillips <kim.phillips@arm.com> wrote:
> > The other thing that's going on here is that I'm becoming numb to the
> > loathsome "failed to mmap with 12 (Cannot allocate memory)" being
> > returned no matter what the error is/was. E.g., an error that would
> > indicate a sense of non-implementation would be much better
> > appreciated than presumably what the above is doing, i.e., returning
> > -ENOMEM.  That, backed up with specific details in the form of human
> > readable text in dmesg would be *most* welcome.
> 
> As part of the refactoring of the code to support CPU-wide scenarios I
> intend to emit better diagnostic messages from the driver.  Modifying
> rb_alloc_aux() to propagate the error message generated by the
> architecture specific PMUs doesn't look hard either and I _may_ get to
> it as part of this work.

For the record, I will continue to oppose PMU drivers that dump diagnostics
about user-controlled input into dmesg, but the coresight drivers are yours
so it's up to you and I won't get in the way!

Will

  reply	other threads:[~2018-08-15  9:39 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18 21:48 [PATCH v3 0/7] perf: Add ioctl for PMU driver configuration Mathieu Poirier
2018-07-18 21:48 ` [PATCH v3 1/7] perf: Introduce ioctl to communicate driver configuration to kernel Mathieu Poirier
2018-07-18 21:48 ` [PATCH v3 2/7] perf/core: Use " Mathieu Poirier
2018-07-18 21:48 ` [PATCH v3 3/7] perf/aux: Make perf_event accessible to setup_aux() Mathieu Poirier
2018-07-18 21:48 ` [PATCH v3 4/7] coresight: Use PMU driver configuration for sink selection Mathieu Poirier
2018-07-18 21:48 ` [PATCH v3 5/7] perf tools: Use ioctl to communicate driver configuration to kernel Mathieu Poirier
2018-07-18 21:48 ` [PATCH v3 6/7] perf tools: Make perf_evsel accessible to PMU driver configuration code Mathieu Poirier
2018-07-18 21:48 ` [PATCH v3 7/7] perf tools: Use ioctl function to send sink configuration to kernel Mathieu Poirier
2018-08-13 17:46 ` [PATCH v3 0/7] perf: Add ioctl for PMU driver configuration Kim Phillips
2018-08-14 16:15   ` Mathieu Poirier
2018-08-14 17:09     ` Kim Phillips
2018-08-14 19:42       ` Mathieu Poirier
2018-08-15  9:39         ` Will Deacon [this message]
2018-08-15 15:28           ` Kim Phillips
2018-08-16 19:28             ` Mathieu Poirier
2018-08-20 10:03               ` Suzuki K Poulose
2018-08-20 14:22                 ` Kim Phillips
2018-08-20 14:36                   ` Suzuki K Poulose
2018-08-20 15:25                     ` Kim Phillips
2018-08-21  8:39                       ` Suzuki K Poulose
2018-08-21 14:47                         ` Kim Phillips
2018-08-21 17:16                     ` Mathieu Poirier
2018-08-21 19:17                       ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180815093912.GE2427@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).