From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@bootlin.com (Maxime Ripard) Date: Fri, 24 Aug 2018 16:32:47 +0200 Subject: [PATCH] drm/sun4i: tcon-top: Use struct_size() in devm_kzalloc() In-Reply-To: References: <20180824010521.GA25451@embeddedor.com> Message-ID: <20180824143247.7lxwsckmkyaiqzob@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Aug 23, 2018 at 07:56:12PM -0700, Kees Cook wrote: > On Thu, Aug 23, 2018 at 6:05 PM, Gustavo A. R. Silva > wrote: > > One of the more common cases of allocation size calculations is finding > > the size of a structure that has a zero-sized array at the end, along > > with memory for some number of elements for that array. For example: > > > > struct foo { > > int stuff; > > void *entry[]; > > }; > > > > instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); > > > > Instead of leaving these open-coded and prone to type mistakes, we can > > now use the new struct_size() helper: > > > > instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL); > > > > This issue was detected with the help of Coccinelle. > > > > Signed-off-by: Gustavo A. R. Silva > > Reviewed-by: Kees Cook Applied, thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: