[PATCH 0/5] ARM: dts: at91: nattis: some cleanup

[PATCH 0/5] ARM: dts: at91: nattis: some cleanup

[Peter Rosin]

Hi!

Now that some other patches [1][2] have finally landed in -next, I
feel that it is time for this cleanup series that I have been hoarding
for a while waiting on those (weak) dependencies.

Cheers,
Peter

[1] https://lkml.org/lkml/2018/8/24/187
[2] https://lkml.org/lkml/2018/8/25/64

Peter Rosin (5):
  ARM: dts: at91: nattis: set the PRLUD and HIPOW signals low
  ARM: dts: at91: nattis: make the SD-card slot work
  ARM: dts: at91: nattis: state the actual lvds-encoder chip
  ARM: dts: at91: nattis: move pinctrls for the lvds chip to the lvds
    node
  ARM: dts: at91: nattis: describe the lvds panel

 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 43 ++++++++++++++++++++++-------
 1 file changed, 33 insertions(+), 10 deletions(-)

-- 
2.11.0

[PATCH 1/5] ARM: dts: at91: nattis: set the PRLUD and HIPOW signals low

[Peter Rosin]

AT91_PINCTRL_OUTPUT_VAL(0) without AT91_PINCTRL_OUTPUT is a no-op, so
make sure the pins really output a zero.

Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power")
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
index af9f38456d04..bfa5815a0721 100644
--- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
+++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
@@ -38,14 +38,16 @@
 						atmel,pins =
 							<AT91_PIOA 21
 							 AT91_PERIPH_GPIO
-							 AT91_PINCTRL_OUTPUT_VAL(0)>;
+							 (AT91_PINCTRL_OUTPUT |
+							  AT91_PINCTRL_OUTPUT_VAL(0))>;
 					};
 
 					pinctrl_lcd_hipow0: lcd_hipow0 {
 						atmel,pins =
 							<AT91_PIOA 23
 							 AT91_PERIPH_GPIO
-							 AT91_PINCTRL_OUTPUT_VAL(0)>;
+							 (AT91_PINCTRL_OUTPUT |
+							  AT91_PINCTRL_OUTPUT_VAL(0))>;
 					};
 				};
 			};
-- 
2.11.0

[PATCH 2/5] ARM: dts: at91: nattis: make the SD-card slot work

[Peter Rosin]

The cd-gpios signal is assumed active-low by the driver, and the
cd-inverted property is needed if it is, in fact, active-high. Fix
this oversight.

Fixes: 0e4323899973 ("ARM: dts: at91: add devicetree for the Axentia Nattis with Natte power")
Signed-off-by: Peter Rosin <peda@axentia.se>
---
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
index bfa5815a0721..4308a07b792e 100644
--- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
+++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
@@ -221,6 +221,7 @@
 		reg = <0>;
 		bus-width = <4>;
 		cd-gpios = <&pioD 5 GPIO_ACTIVE_HIGH>;
+		cd-inverted;
 	};
 };
 
-- 
2.11.0

[PATCH 3/5] ARM: dts: at91: nattis: state the actual lvds-encoder chip

[Peter Rosin]

Just to be explicit.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
index 4308a07b792e..fbc796125c56 100644
--- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
+++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
@@ -117,7 +117,7 @@
 	};
 
 	lvds-encoder {
-		compatible = "lvds-encoder";
+		compatible = "ti,ds90c185", "lvds-encoder";
 
 		ports {
 			#address-cells = <1>;
-- 
2.11.0

[PATCH 4/5] ARM: dts: at91: nattis: move pinctrls for the lvds chip to the lvds node

[Peter Rosin]

The atmel hlcdc controller has nothing to do with these pins, so move
them to where they belong.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
index fbc796125c56..2eb0f947ab86 100644
--- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
+++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
@@ -34,7 +34,7 @@
 							 AT91_PINCTRL_PULL_UP_DEGLITCH>;
 					};
 
-					pinctrl_lcd_prlud0: lcd_prlud0 {
+					pinctrl_lvds_prlud0: lvds_prlud0 {
 						atmel,pins =
 							<AT91_PIOA 21
 							 AT91_PERIPH_GPIO
@@ -42,7 +42,7 @@
 							  AT91_PINCTRL_OUTPUT_VAL(0))>;
 					};
 
-					pinctrl_lcd_hipow0: lcd_hipow0 {
+					pinctrl_lvds_hipow0: lvds_hipow0 {
 						atmel,pins =
 							<AT91_PIOA 23
 							 AT91_PERIPH_GPIO
@@ -119,6 +119,9 @@
 	lvds-encoder {
 		compatible = "ti,ds90c185", "lvds-encoder";
 
+		pinctrl-names = "default";
+		pinctrl-0 = <&pinctrl_lvds_prlud0 &pinctrl_lvds_hipow0>;
+
 		ports {
 			#address-cells = <1>;
 			#size-cells = <0>;
@@ -197,10 +200,7 @@
 
 	hlcdc-display-controller {
 		pinctrl-names = "default";
-		pinctrl-0 = <&pinctrl_lcd_base
-			     &pinctrl_lcd_rgb565
-			     &pinctrl_lcd_prlud0
-			     &pinctrl_lcd_hipow0>;
+		pinctrl-0 = <&pinctrl_lcd_base &pinctrl_lcd_rgb565>;
 
 		port at 0 {
 			hlcdc_output: endpoint {
-- 
2.11.0

[PATCH 5/5] ARM: dts: at91: nattis: describe the lvds panel

[Peter Rosin]

Make the DT usable with the panel-lvds driver.

Signed-off-by: Peter Rosin <peda@axentia.se>
---
 arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
index 2eb0f947ab86..97e972aefac2 100644
--- a/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
+++ b/arch/arm/boot/dts/at91-nattis-2-natte-2.dts
@@ -105,10 +105,29 @@
 	};
 
 	panel: panel {
-		compatible = "sharp,lq150x1lg11";
+		compatible = "sharp,lq150x1lg11", "panel-lvds";
+
 		backlight = <&panel_bl>;
 		power-supply = <&panel_reg>;
 
+		width-mm = <304>;
+		height-mm = <228>;
+
+		data-mapping = "jeida-18";
+
+		panel-timing {
+			// 1024x768 @ 60Hz (typical)
+			clock-frequency = <50000000 65000000 80000000>;
+			hactive = <1024>;
+			vactive = <768>;
+			hfront-porch = <48 88 88>;
+			hback-porch = <96 168 168>;
+			hsync-len = <32 64 64>;
+			vsync-len = <3 13 74>;
+			vfront-porch = <3 13 74>;
+			vback-porch = <3 12 74>;
+		};
+
 		port {
 			panel_input: endpoint {
 				remote-endpoint = <&lvds_encoder_output>;
@@ -205,6 +224,7 @@
 		port at 0 {
 			hlcdc_output: endpoint {
 				remote-endpoint = <&lvds_encoder_input>;
+				bus-width = <16>;
 			};
 		};
 	};
-- 
2.11.0

[PATCH 0/5] ARM: dts: at91: nattis: some cleanup

[Alexandre Belloni]

On 28/08/2018 11:48:39+0200, Peter Rosin wrote:
> Hi!
> 
> Now that some other patches [1][2] have finally landed in -next, I
> feel that it is time for this cleanup series that I have been hoarding
> for a while waiting on those (weak) dependencies.
> 
> Cheers,
> Peter
> 
> [1] https://lkml.org/lkml/2018/8/24/187
> [2] https://lkml.org/lkml/2018/8/25/64
> 
> Peter Rosin (5):
>   ARM: dts: at91: nattis: set the PRLUD and HIPOW signals low
>   ARM: dts: at91: nattis: make the SD-card slot work
>   ARM: dts: at91: nattis: state the actual lvds-encoder chip
>   ARM: dts: at91: nattis: move pinctrls for the lvds chip to the lvds
>     node
>   ARM: dts: at91: nattis: describe the lvds panel
> 
>  arch/arm/boot/dts/at91-nattis-2-natte-2.dts | 43 ++++++++++++++++++++++-------
>  1 file changed, 33 insertions(+), 10 deletions(-)
> 

All applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com