linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RESEND] arm64: don't dump stack for usermode address in show_regs
Date: Wed, 29 Aug 2018 18:11:32 +0100	[thread overview]
Message-ID: <20180829171131.GA11160@brain-police> (raw)
In-Reply-To: <e5f4011a-e0a0-b5be-599f-5adc32155d87@huawei.com>

On Wed, Aug 29, 2018 at 10:58:00PM +0800, Ding Tianhong wrote:
> On 2018/8/29 19:54, Will Deacon wrote:
> > This looks like we're somehow dereferencing the user frame-pointer from the
> > READ_ONCE_NOCHECK in unwind_frame(). However, I really don't see how that
> > can happen, since the kernel entry code pushes a dummy frame record or
> > zeroes, which will terminate any backtrace before we hit the user
> > addresses. Furthermore, we explicitly check that the frame pointer points
> > to an accessible stack before we dereference it. Hmm.
> > 
> 
> I found the patch 12964443e8d1 ("arm64: add on_accessible_stack()")
> already fix this in kernel v4.14, my kernel version is older than this and
> miss this patch for a long time, so I think this is the reason that I met
> this problem, thanks for remind me.

Ok, but in future please state up-front if you're reporting an issue that
you're seeing on something older than mainline. I spent an hour reading
through this code today looking for a bug we'd already fixed :(

Will

      reply	other threads:[~2018-08-29 17:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 10:17 [PATCH RESEND] arm64: don't dump stack for usermode address in show_regs Ding Tianhong
2018-08-29 11:54 ` Will Deacon
2018-08-29 14:58   ` Ding Tianhong
2018-08-29 17:11     ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180829171131.GA11160@brain-police \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).