* [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin [not found] <20180831191732.25504-1-afd@ti.com> @ 2018-09-03 4:54 ` Shawn Guo 2018-09-04 13:35 ` Andrew F. Davis 0 siblings, 1 reply; 2+ messages in thread From: Shawn Guo @ 2018-09-03 4:54 UTC (permalink / raw) To: linux-arm-kernel On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote: > The correct DT property for specifying a GPIO used for reset > is "reset-gpios", fix this here. > > Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards") This Fixes tag and word 'Fix' in subject is inappropriate to me, as you are not fixing something wrong from the beginning, but actually replacing a deprecated property with new one. Shawn > > Signed-off-by: Andrew F. Davis <afd@ti.com> > --- > arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > index 7fff3717cf7c..a0f5cfda0055 100644 > --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi > @@ -384,7 +384,7 @@ > AVDD-supply = <®_3p3v>; > IOVDD-supply = <®_3p3v>; > DVDD-supply = <&vgen4_reg>; > - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>; > }; > > accel at 1c { > @@ -572,7 +572,7 @@ > AVDD-supply = <®_3p3v>; > IOVDD-supply = <®_3p3v>; > DVDD-supply = <&vgen4_reg>; > - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; > }; > > touchscreen at 20 { > -- > 2.18.0 > ^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin 2018-09-03 4:54 ` [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin Shawn Guo @ 2018-09-04 13:35 ` Andrew F. Davis 0 siblings, 0 replies; 2+ messages in thread From: Andrew F. Davis @ 2018-09-04 13:35 UTC (permalink / raw) To: linux-arm-kernel On 09/02/2018 11:54 PM, Shawn Guo wrote: > On Fri, Aug 31, 2018 at 02:17:31PM -0500, Andrew F. Davis wrote: >> The correct DT property for specifying a GPIO used for reset >> is "reset-gpios", fix this here. >> >> Fixes: d763762e3b58 ("ARM: dts: imx6: add ZII RDU2 boards") > > This Fixes tag and word 'Fix' in subject is inappropriate to me, as you > are not fixing something wrong from the beginning, but actually > replacing a deprecated property with new one. > reset-gpios was standard before this driver got it backwards, but it also wasn't required to be one way or the other as far as I can tell, so I can see your point that this isn't technically "broken". I have no preference, so I'll change the subject and drop the fixes for v2. Andrew > Shawn > >> >> Signed-off-by: Andrew F. Davis <afd@ti.com> >> --- >> arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi >> index 7fff3717cf7c..a0f5cfda0055 100644 >> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi >> @@ -384,7 +384,7 @@ >> AVDD-supply = <®_3p3v>; >> IOVDD-supply = <®_3p3v>; >> DVDD-supply = <&vgen4_reg>; >> - gpio-reset = <&gpio1 2 GPIO_ACTIVE_HIGH>; >> + reset-gpios = <&gpio1 2 GPIO_ACTIVE_LOW>; >> }; >> >> accel at 1c { >> @@ -572,7 +572,7 @@ >> AVDD-supply = <®_3p3v>; >> IOVDD-supply = <®_3p3v>; >> DVDD-supply = <&vgen4_reg>; >> - gpio-reset = <&gpio1 0 GPIO_ACTIVE_HIGH>; >> + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; >> }; >> >> touchscreen at 20 { >> -- >> 2.18.0 >> ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-04 13:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180831191732.25504-1-afd@ti.com>
2018-09-03 4:54 ` [PATCH 1/2] ARM: dts: imx6: RDU2: Fix the audio CODEC's reset pin Shawn Guo
2018-09-04 13:35 ` Andrew F. Davis
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox