[PATCH 3/5] spi: pxa2xx: use an enum for type

Robert Jarzmik
2018-09-21T20:34:03Z

Lubomir Rintel <lkundrak@v3.sk> writes:

> That seems to be the correct type.
Okay, but what happens here when adev_id->driver_data is a value out of enum
range ? Does the following assignment make sense ?
> + type = (enum pxa_ssp_type)adev_id->driver_data;

As a side note, could you join for the next throw to the review :
- Jarkko Nikula <jarkko.nikula@linux.intel.com>
- Mika Westerberg <mika.westerberg@linux.intel.com>

Even if they are Intel, I think they have worked a lot on this driver for Intel
platforms.

Cheers.

--
Robert