From mboxrd@z Thu Jan 1 00:00:00 1970 From: vkoul@kernel.org (Vinod) Date: Tue, 11 Sep 2018 13:11:22 +0530 Subject: [PATCH 3/3] dmaengine: xilinx_dma: Fix 64-bit simple CDMA transfer In-Reply-To: References: <1532688639-32230-1-git-send-email-radhey.shyam.pandey@xilinx.com> <1532688639-32230-4-git-send-email-radhey.shyam.pandey@xilinx.com> <20180821155553.GI2388@vkoul-mobl> <20180829040111.GD2388@vkoul-mobl> Message-ID: <20180911074122.GM2634@vkoul-mobl> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07-09-18, 12:08, Radhey Shyam Pandey wrote: > > > Yeah that part was clear but the implementation can be better.. > I thought over it and it seems having a new interface dma_ctrl_write_64 > taking lsb and msb bits input looks better and scalable. It will be similar > to existing vdma_desc_write_64 impl. I will send v2 if it looks ok. Yes that is much better, btw why not reuse same routine as common xilinx lib functions :) -- ~Vinod