linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: romain.izard.pro@gmail.com (Romain Izard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] watchdog: sama5d4: fix timeout-sec usage
Date: Fri, 14 Sep 2018 12:13:38 +0200	[thread overview]
Message-ID: <20180914101339.7382-2-romain.izard.pro@gmail.com> (raw)
In-Reply-To: <20180914101339.7382-1-romain.izard.pro@gmail.com>

When using watchdog_init_timeout to update the default timeout value,
an error means that there is no "timeout-sec" in the relevant device
tree node.

This should not prevent binding of the driver to the device.

Fixes: 976932e40036 ("watchdog: sama5d4: make use of timeout-secs provided in devicetree")
Signed-off-by: Romain Izard <romain.izard.pro@gmail.com>
---
 drivers/watchdog/sama5d4_wdt.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/watchdog/sama5d4_wdt.c b/drivers/watchdog/sama5d4_wdt.c
index 255169916dbb..1e93c1b0e3cf 100644
--- a/drivers/watchdog/sama5d4_wdt.c
+++ b/drivers/watchdog/sama5d4_wdt.c
@@ -247,11 +247,7 @@ static int sama5d4_wdt_probe(struct platform_device *pdev)
 		}
 	}
 
-	ret = watchdog_init_timeout(wdd, wdt_timeout, &pdev->dev);
-	if (ret) {
-		dev_err(&pdev->dev, "unable to set timeout value\n");
-		return ret;
-	}
+	watchdog_init_timeout(wdd, wdt_timeout, &pdev->dev);
 
 	timeout = WDT_SEC2TICKS(wdd->timeout);
 
-- 
2.17.1

  reply	other threads:[~2018-09-14 10:13 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14 10:13 [PATCH 0/2] Fixes for the SAMA5D2/SAMA5D4 watchdog Romain Izard
2018-09-14 10:13 ` Romain Izard [this message]
2018-09-14 13:37   ` [PATCH 1/2] watchdog: sama5d4: fix timeout-sec usage Guenter Roeck
2018-09-15 13:46   ` Marcus Folkesson
2018-09-14 10:13 ` [PATCH 2/2] watchdog: sama5d4: write the mode register in two steps Romain Izard
2018-09-14 10:27   ` Alexandre Belloni
2018-09-17 13:58     ` Romain Izard
2018-10-01 15:52       ` Alexandre Belloni
2018-09-14 21:29   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180914101339.7382-2-romain.izard.pro@gmail.com \
    --to=romain.izard.pro@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).