From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6] ARM: shmobile: Rework the PMIC IRQ line quirk
Date: Wed, 19 Sep 2018 11:41:04 +0200 [thread overview]
Message-ID: <20180919094100.gtlxbthzgamixequ@verge.net.au> (raw)
In-Reply-To: <7d214a60-e703-c53d-5c98-5da29c34650f@gmail.com>
On Wed, Sep 19, 2018 at 11:21:42AM +0200, Marek Vasut wrote:
> On 09/19/2018 11:13 AM, Simon Horman wrote:
> > On Tue, Sep 18, 2018 at 02:52:53PM +0200, Geert Uytterhoeven wrote:
> >> On Tue, Sep 18, 2018 at 2:23 PM Marek Vasut <marek.vasut@gmail.com> wrote:
> >>> Rather than hard-coding the quirk topology, which stopped scaling,
> >>> parse the information from DT. The code looks for all compatible
> >>> PMICs -- da9063 and da9210 -- and checks if their IRQ line is tied
> >>> to the same pin. If so, the code sends a matching sequence to the
> >>> PMIC to deassert the IRQ.
> >>>
> >>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> >>> Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> >>> Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >>> Cc: Simon Horman <horms+renesas@verge.net.au>
> >>> Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >>> Cc: linux-renesas-soc at vger.kernel.org
> >>> Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >>> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be> (on Koelsch)
> >>> ---
> >>> V2: - Replace the DT shared IRQ check loop with memcmp()
> >>> - Send the I2C message to deassert the IRQ line to all PMICs
> >>> in the list with shared IRQ line instead of just one
> >>> - Add comment that this works only in case all the PMICs are
> >>> on the same I2C bus
> >>> V3: - Drop the addr = 0x00 init
> >>> - Drop reinit of argsa in rcar_gen2_regulator_quirk
> >>> V4: - Squash regulator_quirk on single line
> >>> - Drop !np check in for_each_matching_node_and_match()
> >>> - Use argsa in of_irq_parse_one
> >>> V5: - Check kzalloc failure
> >>> - Rename da...._msgs to da...._msg
> >>> - Don't reinit quirk->shared
> >>> V6: - Skip invalid entries instead of aborting on them
> >>
> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > Thanks, applied for v4.20.
> >
> > Marek, these days checkpatch complains if the author of the patch does not
> > have a signed offline, and the inconsistency between your
> > from and Sign-off the email address trips that check.
> >
> > Could you consider either a) enhancing checkpatch or b) using
> > the same address twice? No need to take any action for this patch.
>
> Sure, do you know if there's some tweak to git config , so git
> send-email uses the m.v+foo@ From address ?
Some sort of local config change sounds good to me.
As per the follow-up from Geert, it may require some experimentation.
prev parent reply other threads:[~2018-09-19 9:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 12:23 [PATCH V6] ARM: shmobile: Rework the PMIC IRQ line quirk Marek Vasut
2018-09-18 12:52 ` Geert Uytterhoeven
2018-09-19 9:13 ` Simon Horman
2018-09-19 9:21 ` Marek Vasut
2018-09-19 9:28 ` Geert Uytterhoeven
2018-09-19 9:30 ` Geert Uytterhoeven
2018-09-19 9:36 ` Marek Vasut
2018-09-19 9:38 ` Geert Uytterhoeven
2018-09-19 9:41 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919094100.gtlxbthzgamixequ@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox