linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [RFC] arm64: lse: remove -fcall-used-x0 flag
@ 2018-09-19 19:27 Tri Vo
  2018-09-21 15:58 ` Will Deacon
  2018-09-24 10:23 ` Catalin Marinas
  0 siblings, 2 replies; 4+ messages in thread
From: Tri Vo @ 2018-09-19 19:27 UTC (permalink / raw)
  To: linux-arm-kernel

x0 is not callee-saved in the PCS. So there is no need to specify
-fcall-used-x0.

Clang doesn't currently support -fcall-used flags. This patch will help
building the kernel with clang.

Signed-off-by: Tri Vo <trong@android.com>
---
 arch/arm64/lib/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/lib/Makefile b/arch/arm64/lib/Makefile
index c86b7909ef31..2f7c60c8e588 100644
--- a/arch/arm64/lib/Makefile
+++ b/arch/arm64/lib/Makefile
@@ -11,7 +11,7 @@ lib-y		:= bitops.o clear_user.o delay.o copy_from_user.o	\
 # when supported by the CPU. Result and argument registers are handled
 # correctly, based on the function prototype.
 lib-$(CONFIG_ARM64_LSE_ATOMICS) += atomic_ll_sc.o
-CFLAGS_atomic_ll_sc.o	:= -fcall-used-x0 -ffixed-x1 -ffixed-x2		\
+CFLAGS_atomic_ll_sc.o	:= -ffixed-x1 -ffixed-x2        		\
 		   -ffixed-x3 -ffixed-x4 -ffixed-x5 -ffixed-x6		\
 		   -ffixed-x7 -fcall-saved-x8 -fcall-saved-x9		\
 		   -fcall-saved-x10 -fcall-saved-x11 -fcall-saved-x12	\
--
2.19.0.397.gdd90340f6a-goog

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [RFC] arm64: lse: remove -fcall-used-x0 flag
  2018-09-19 19:27 [RFC] arm64: lse: remove -fcall-used-x0 flag Tri Vo
@ 2018-09-21 15:58 ` Will Deacon
  2018-09-21 23:47   ` Tri Vo
  2018-09-24 10:23 ` Catalin Marinas
  1 sibling, 1 reply; 4+ messages in thread
From: Will Deacon @ 2018-09-21 15:58 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Sep 19, 2018 at 12:27:50PM -0700, Tri Vo wrote:
> x0 is not callee-saved in the PCS. So there is no need to specify
> -fcall-used-x0.
> 
> Clang doesn't currently support -fcall-used flags. This patch will help
> building the kernel with clang.
> 
> Signed-off-by: Tri Vo <trong@android.com>
> ---
>  arch/arm64/lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

If this is useful to you, then:

Acked-by: Will Deacon <will.deacon@arm.com>

Will

> diff --git a/arch/arm64/lib/Makefile b/arch/arm64/lib/Makefile
> index c86b7909ef31..2f7c60c8e588 100644
> --- a/arch/arm64/lib/Makefile
> +++ b/arch/arm64/lib/Makefile
> @@ -11,7 +11,7 @@ lib-y		:= bitops.o clear_user.o delay.o copy_from_user.o	\
>  # when supported by the CPU. Result and argument registers are handled
>  # correctly, based on the function prototype.
>  lib-$(CONFIG_ARM64_LSE_ATOMICS) += atomic_ll_sc.o
> -CFLAGS_atomic_ll_sc.o	:= -fcall-used-x0 -ffixed-x1 -ffixed-x2		\
> +CFLAGS_atomic_ll_sc.o	:= -ffixed-x1 -ffixed-x2        		\
>  		   -ffixed-x3 -ffixed-x4 -ffixed-x5 -ffixed-x6		\
>  		   -ffixed-x7 -fcall-saved-x8 -fcall-saved-x9		\
>  		   -fcall-saved-x10 -fcall-saved-x11 -fcall-saved-x12	\
> --
> 2.19.0.397.gdd90340f6a-goog
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RFC] arm64: lse: remove -fcall-used-x0 flag
  2018-09-21 15:58 ` Will Deacon
@ 2018-09-21 23:47   ` Tri Vo
  0 siblings, 0 replies; 4+ messages in thread
From: Tri Vo @ 2018-09-21 23:47 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Sep 21, 2018 at 8:58 AM Will Deacon <will.deacon@arm.com> wrote:
>
> On Wed, Sep 19, 2018 at 12:27:50PM -0700, Tri Vo wrote:
> > x0 is not callee-saved in the PCS. So there is no need to specify
> > -fcall-used-x0.
> >
> > Clang doesn't currently support -fcall-used flags. This patch will help
> > building the kernel with clang.
> >
> > Signed-off-by: Tri Vo <trong@android.com>
> > ---
> >  arch/arm64/lib/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> If this is useful to you, then:
>
> Acked-by: Will Deacon <will.deacon@arm.com>

Thank you!
>
> Will
>
> > diff --git a/arch/arm64/lib/Makefile b/arch/arm64/lib/Makefile
> > index c86b7909ef31..2f7c60c8e588 100644
> > --- a/arch/arm64/lib/Makefile
> > +++ b/arch/arm64/lib/Makefile
> > @@ -11,7 +11,7 @@ lib-y               := bitops.o clear_user.o delay.o copy_from_user.o       \
> >  # when supported by the CPU. Result and argument registers are handled
> >  # correctly, based on the function prototype.
> >  lib-$(CONFIG_ARM64_LSE_ATOMICS) += atomic_ll_sc.o
> > -CFLAGS_atomic_ll_sc.o        := -fcall-used-x0 -ffixed-x1 -ffixed-x2         \
> > +CFLAGS_atomic_ll_sc.o        := -ffixed-x1 -ffixed-x2                        \
> >                  -ffixed-x3 -ffixed-x4 -ffixed-x5 -ffixed-x6          \
> >                  -ffixed-x7 -fcall-saved-x8 -fcall-saved-x9           \
> >                  -fcall-saved-x10 -fcall-saved-x11 -fcall-saved-x12   \
> > --
> > 2.19.0.397.gdd90340f6a-goog
> >

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [RFC] arm64: lse: remove -fcall-used-x0 flag
  2018-09-19 19:27 [RFC] arm64: lse: remove -fcall-used-x0 flag Tri Vo
  2018-09-21 15:58 ` Will Deacon
@ 2018-09-24 10:23 ` Catalin Marinas
  1 sibling, 0 replies; 4+ messages in thread
From: Catalin Marinas @ 2018-09-24 10:23 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Sep 19, 2018 at 12:27:50PM -0700, Tri Vo wrote:
> x0 is not callee-saved in the PCS. So there is no need to specify
> -fcall-used-x0.
> 
> Clang doesn't currently support -fcall-used flags. This patch will help
> building the kernel with clang.
> 
> Signed-off-by: Tri Vo <trong@android.com>

Queued for 4.20. Thanks.

-- 
Catalin

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-09-24 10:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-19 19:27 [RFC] arm64: lse: remove -fcall-used-x0 flag Tri Vo
2018-09-21 15:58 ` Will Deacon
2018-09-21 23:47   ` Tri Vo
2018-09-24 10:23 ` Catalin Marinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).