From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V6 2/3] firmware: imx: add SCU firmware driver support
Date: Thu, 20 Sep 2018 08:52:20 +0200 [thread overview]
Message-ID: <20180920065219.GT4097@pengutronix.de> (raw)
In-Reply-To: <AM0PR04MB4211FB690E079766D364E94F80130@AM0PR04MB4211.eurprd04.prod.outlook.com>
On Thu, Sep 20, 2018 at 06:41:15AM +0000, A.s. Dong wrote:
> > > > Could you give the exported functions a better namespace like imx_scu_*?
> > > >
> > >
> > > Good idea.
> > > Should we change all the rest as well?
> >
> > You mean enums and such? Yes, that would be good.
>
> I mean other functions and struct names. All prefixed by imx_scu.
> Enums still not changed.
I don't really care about stuff that's internal to a single C file, but
everything that is globally visible should have a proper namespace,
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2018-09-20 6:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 3:04 [PATCH V6 0/3] soc: imx: add scu firmware api support Dong Aisheng
2018-09-19 3:04 ` [PATCH V6 1/3] dt-bindings: arm: fsl: add scu binding doc Dong Aisheng
2018-09-19 3:04 ` [PATCH V6 2/3] firmware: imx: add SCU firmware driver support Dong Aisheng
2018-09-19 19:41 ` Sascha Hauer
2018-09-20 2:27 ` A.s. Dong
2018-09-20 6:33 ` Sascha Hauer
2018-09-20 6:41 ` A.s. Dong
2018-09-20 6:52 ` Sascha Hauer [this message]
2018-09-20 6:58 ` A.s. Dong
2018-09-19 3:04 ` [PATCH V6 3/3] firmware: imx: add misc svc support Dong Aisheng
2018-09-19 20:21 ` Sascha Hauer
2018-09-20 2:46 ` A.s. Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180920065219.GT4097@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).