From mboxrd@z Thu Jan 1 00:00:00 1970 From: maxime.ripard@bootlin.com (Maxime Ripard) Date: Fri, 21 Sep 2018 16:26:54 +0200 Subject: [PATCH] drm: sun4i: Fix a uninitialized variable warning. In-Reply-To: <5BA2106C.2080007@huawei.com> References: <1537255520-41614-1-git-send-email-zhongjiang@huawei.com> <20180919084719.6ymf6h4eftomfab3@flea> <5BA2106C.2080007@huawei.com> Message-ID: <20180921142654.ahuhswypvscjsuyj@flea> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Sep 19, 2018 at 05:01:32PM +0800, zhong jiang wrote: > On 2018/9/19 16:47, Maxime Ripard wrote: > > On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote: > >> Fix the following compile warning: > >> > >> drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may be used uninitialized in this function [-Wmaybe-uninitialized] > >> bool has_lvds_rst, has_lvds_alt, can_lvds; > >> > >> Signed-off-by: zhong jiang > > I can't see any code path that would lead to an uninitialized usage of > > that variable. > > > > Which compiler produced that warning? I tried building it today with > > gcc 8.1.1, and I don't see that warning either. > > I indeed hit the issue. the gcc version is > gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 I've tested with 4.* gcc, and it didn't report any error. It seems to be a false positive for this particular version, so there's no need to merge that patch. If more people are affected, we'll obviously do something about it though. Thanks! Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: