linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] arm64: lse: remove -fcall-used-x0 flag
Date: Fri, 21 Sep 2018 16:58:29 +0100	[thread overview]
Message-ID: <20180921155829.GD1451@arm.com> (raw)
In-Reply-To: <20180919192750.200491-1-trong@android.com>

On Wed, Sep 19, 2018 at 12:27:50PM -0700, Tri Vo wrote:
> x0 is not callee-saved in the PCS. So there is no need to specify
> -fcall-used-x0.
> 
> Clang doesn't currently support -fcall-used flags. This patch will help
> building the kernel with clang.
> 
> Signed-off-by: Tri Vo <trong@android.com>
> ---
>  arch/arm64/lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

If this is useful to you, then:

Acked-by: Will Deacon <will.deacon@arm.com>

Will

> diff --git a/arch/arm64/lib/Makefile b/arch/arm64/lib/Makefile
> index c86b7909ef31..2f7c60c8e588 100644
> --- a/arch/arm64/lib/Makefile
> +++ b/arch/arm64/lib/Makefile
> @@ -11,7 +11,7 @@ lib-y		:= bitops.o clear_user.o delay.o copy_from_user.o	\
>  # when supported by the CPU. Result and argument registers are handled
>  # correctly, based on the function prototype.
>  lib-$(CONFIG_ARM64_LSE_ATOMICS) += atomic_ll_sc.o
> -CFLAGS_atomic_ll_sc.o	:= -fcall-used-x0 -ffixed-x1 -ffixed-x2		\
> +CFLAGS_atomic_ll_sc.o	:= -ffixed-x1 -ffixed-x2        		\
>  		   -ffixed-x3 -ffixed-x4 -ffixed-x5 -ffixed-x6		\
>  		   -ffixed-x7 -fcall-saved-x8 -fcall-saved-x9		\
>  		   -fcall-saved-x10 -fcall-saved-x11 -fcall-saved-x12	\
> --
> 2.19.0.397.gdd90340f6a-goog
> 

  reply	other threads:[~2018-09-21 15:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 19:27 [RFC] arm64: lse: remove -fcall-used-x0 flag Tri Vo
2018-09-21 15:58 ` Will Deacon [this message]
2018-09-21 23:47   ` Tri Vo
2018-09-24 10:23 ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180921155829.GD1451@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).