linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: beagleboard@davidjohnsummers.uk (David Summers)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] Device Tree for ASUS Tinker Board S [v3]
Date: Sat, 22 Sep 2018 18:02:33 +0100	[thread overview]
Message-ID: <20180922170236.8690-1-beagleboard@davidjohnsummers.uk> (raw)

So third try on these patches, hope these work, git commands are difficult
So I hope these work.

The ASUS Tinker Board S : https://www.asus.com/uk/Single-Board-Computer/Tinker-Board-S/

Is a variant on the original ASUS Tinker Board, the main difference being that the "S" has eMMC.

This patchset sets up the device tree for the "S". It is based on the patches used with the debian distribution which ships with the device : https://github.com/TinkerBoard/debian_kernel/blob/develop/arch/arm/boot/dts/rk3288-miniarm.dts

So this is really just mainlining the support.

I've split the changed into three parts:

  .  This part - just creates a new dts file that is a copy of the tinker board, with just a name change
  .  Changes needed to add the eMMC
It is based on: https://github.com/TinkerBoard/debian_kernel/commit/dc7d4eb4140b4e5ff23aaf2864a56d5c8634f3d0

With the speed change from

https://github.com/TinkerBoard/debian_kernel/commit/4b52627037958bc95ed3f67ff96bbbadbb2bfe07

The patch is relatively straight forward. Only oddity that it seems to be on the sd card slot at &sdmmc; when booting from eMMC and there is no card in the sd slot - then the kernel keeps scanning the sd slot. So it looks like card detect isn't functioning correctly on &sdmmc. This probably wasn't noted on the original Tinker Board, as that had to have a sd card in order to boot. Alas the schematic for the tinker board doesn't show how the sd card is wired ...:

http://dlcdnet.asus.com/pub/ASUS/mb/Linux/Tinker_Board_2GB/Tinker_Board_Schematics.zip
  .  Changes needed to enable wifi
Its based on: https://github.com/TinkerBoard/debian_kernel/commit/6a3128ade33f758887048578ada61a4b7ab8e678

The changes here are more extensive, basic communication is via sdio0, but can also be seen that connections are set up to the RK808 e.g. the power management chip.

This is the first patch I've done for linux - so if I've got anything wrong, just let me know and I'll correct.

Also any comments you have.

Regards,

David Summers

David Summers (3):
  Add the tinker board S to the device tree - just an outline
  This patch add the eMMC to the ASUS tinker board S
  This patch adds wifi to asus tinker board S
  

 .../devicetree/bindings/arm/rockchip.txt      |   4 +
 arch/arm/boot/dts/Makefile                    |   1 +
 arch/arm/boot/dts/rk3288-tinker-s.dts         | 120 +++++
 arch/arm/boot/dts/rk3288-tinker.dts           | 498 +----------------
 arch/arm/boot/dts/rk3288-tinker.dtsi          | 504 ++++++++++++++++++
 5 files changed, 631 insertions(+), 496 deletions(-)
 create mode 100644 arch/arm/boot/dts/rk3288-tinker-s.dts
 create mode 100644 arch/arm/boot/dts/rk3288-tinker.dtsi

-- 
David Summers <beagleboard@davididjohnsummers.uk>

             reply	other threads:[~2018-09-22 17:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-22 17:02 David Summers [this message]
2018-09-22 17:02 ` [PATCH 1/3] Add the tinker board S to the device tree - just an outline David Summers
2018-10-15 16:12   ` Rob Herring
2018-10-15 16:49     ` David Summers
2018-09-22 17:02 ` [PATCH 2/3] This patch add the eMMC to the ASUS tinker board S David Summers
2018-09-22 17:02 ` [PATCH 3/3] This patch adds wifi to asus " David Summers
2018-10-08  9:30   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180922170236.8690-1-beagleboard@davidjohnsummers.uk \
    --to=beagleboard@davidjohnsummers.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).