linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] soc: imx: gpc: set DMA mask for PD platform devices
@ 2018-09-12 15:27 Lucas Stach
  2018-09-13  3:51 ` Fabio Estevam
  2018-09-26  2:39 ` Shawn Guo
  0 siblings, 2 replies; 6+ messages in thread
From: Lucas Stach @ 2018-09-12 15:27 UTC (permalink / raw)
  To: linux-arm-kernel

The PD platform devices aren't DMA capable (as is correctly reflected
in with a zero mask coherent_dma_mask). As they have a of_node attached
they will go through of_dma_configure, which will warn if it finds an
uninitialized DMA mask. Let the driver core know that this isn't a
missing configuration, but a non DMA capable device by pointing the
dma_mask to the coherent_dma_mask.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
Since the warning that is triggered with the incomplete configuration
has been introduced in the v4.19 cycle, it would nice to get this in
as a fix.
---
 drivers/soc/imx/gpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
index f301fcd96c07..a897c851f305 100644
--- a/drivers/soc/imx/gpc.c
+++ b/drivers/soc/imx/gpc.c
@@ -493,6 +493,7 @@ static int imx_gpc_probe(struct platform_device *pdev)
 
 			pd_pdev->dev.parent = &pdev->dev;
 			pd_pdev->dev.of_node = np;
+			pd_pdev->dev.dma_mask = &pd_pdev->dev.coherent_dma_mask;
 
 			ret = platform_device_add(pd_pdev);
 			if (ret) {
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] soc: imx: gpc: set DMA mask for PD platform devices
  2018-09-12 15:27 [PATCH] soc: imx: gpc: set DMA mask for PD platform devices Lucas Stach
@ 2018-09-13  3:51 ` Fabio Estevam
  2018-09-26  2:39 ` Shawn Guo
  1 sibling, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2018-09-13  3:51 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Lucas,

On Wed, Sep 12, 2018 at 12:27 PM, Lucas Stach <l.stach@pengutronix.de> wrote:
> The PD platform devices aren't DMA capable (as is correctly reflected
> in with a zero mask coherent_dma_mask). As they have a of_node attached
> they will go through of_dma_configure, which will warn if it finds an
> uninitialized DMA mask. Let the driver core know that this isn't a
> missing configuration, but a non DMA capable device by pointing the
> dma_mask to the coherent_dma_mask.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

This fixes the following warnings seen on imx6q-sabresd:

[    1.323046] imx-pgc-pd imx-pgc-power-domain.0: DMA mask not set
[    1.323700] imx-pgc-pd imx-pgc-power-domain.1: DMA mask not set

Tested-by: Fabio Estevam <fabio.estevam@nxp.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] soc: imx: gpc: set DMA mask for PD platform devices
  2018-09-12 15:27 [PATCH] soc: imx: gpc: set DMA mask for PD platform devices Lucas Stach
  2018-09-13  3:51 ` Fabio Estevam
@ 2018-09-26  2:39 ` Shawn Guo
  2019-01-24 11:46   ` Fabio Estevam
  1 sibling, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2018-09-26  2:39 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Sep 12, 2018 at 05:27:02PM +0200, Lucas Stach wrote:
> The PD platform devices aren't DMA capable (as is correctly reflected
> in with a zero mask coherent_dma_mask). As they have a of_node attached
> they will go through of_dma_configure, which will warn if it finds an
> uninitialized DMA mask. Let the driver core know that this isn't a
> missing configuration, but a non DMA capable device by pointing the
> dma_mask to the coherent_dma_mask.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Since the warning that is triggered with the incomplete configuration
> has been introduced in the v4.19 cycle, it would nice to get this in
> as a fix.

Applied as a fix, thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] soc: imx: gpc: set DMA mask for PD platform devices
  2018-09-26  2:39 ` Shawn Guo
@ 2019-01-24 11:46   ` Fabio Estevam
  2019-01-24 14:34     ` Lucas Stach
  0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2019-01-24 11:46 UTC (permalink / raw)
  To: Shawn Guo
  Cc: patchwork-lst, NXP Linux Team, Sascha Hauer, Fabio Estevam,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	Lucas Stach

Hi Shawn,

On Tue, Sep 25, 2018 at 11:41 PM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Wed, Sep 12, 2018 at 05:27:02PM +0200, Lucas Stach wrote:
> > The PD platform devices aren't DMA capable (as is correctly reflected
> > in with a zero mask coherent_dma_mask). As they have a of_node attached
> > they will go through of_dma_configure, which will warn if it finds an
> > uninitialized DMA mask. Let the driver core know that this isn't a
> > missing configuration, but a non DMA capable device by pointing the
> > dma_mask to the coherent_dma_mask.
> >
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > Since the warning that is triggered with the incomplete configuration
> > has been introduced in the v4.19 cycle, it would nice to get this in
> > as a fix.
>
> Applied as a fix, thanks.

Did you forget to push this change? I still don't see it applied.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] soc: imx: gpc: set DMA mask for PD platform devices
  2019-01-24 11:46   ` Fabio Estevam
@ 2019-01-24 14:34     ` Lucas Stach
  2019-01-24 17:41       ` Fabio Estevam
  0 siblings, 1 reply; 6+ messages in thread
From: Lucas Stach @ 2019-01-24 14:34 UTC (permalink / raw)
  To: Fabio Estevam, Shawn Guo
  Cc: Fabio Estevam, Sascha Hauer, NXP Linux Team,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
	patchwork-lst

Hi Fabio,

Am Donnerstag, den 24.01.2019, 09:46 -0200 schrieb Fabio Estevam:
> Hi Shawn,
> 
> On Tue, Sep 25, 2018 at 11:41 PM Shawn Guo <shawnguo@kernel.org>
> wrote:
> > 
> > On Wed, Sep 12, 2018 at 05:27:02PM +0200, Lucas Stach wrote:
> > > The PD platform devices aren't DMA capable (as is correctly
> > > reflected
> > > in with a zero mask coherent_dma_mask). As they have a of_node
> > > attached
> > > they will go through of_dma_configure, which will warn if it
> > > finds an
> > > uninitialized DMA mask. Let the driver core know that this isn't
> > > a
> > > missing configuration, but a non DMA capable device by pointing
> > > the
> > > dma_mask to the coherent_dma_mask.
> > > 
> > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > > Since the warning that is triggered with the incomplete
> > > configuration
> > > has been introduced in the v4.19 cycle, it would nice to get this
> > > in
> > > as a fix.
> > 
> > Applied as a fix, thanks.
> 
> Did you forget to push this change? I still don't see it applied.

It was dropped due to discussion in the pull request:

https://patchwork.kernel.org/patch/10621589/

It seems we are stuck there and I don't have the bandwidth to follow up
with this currently.

Regards,
Lucas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] soc: imx: gpc: set DMA mask for PD platform devices
  2019-01-24 14:34     ` Lucas Stach
@ 2019-01-24 17:41       ` Fabio Estevam
  0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2019-01-24 17:41 UTC (permalink / raw)
  To: Lucas Stach
  Cc: patchwork-lst, NXP Linux Team, Sascha Hauer, Fabio Estevam,
	Shawn Guo,
	moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE

Hi Lucas,

On Thu, Jan 24, 2019 at 12:34 PM Lucas Stach <l.stach@pengutronix.de> wrote:

> It was dropped due to discussion in the pull request:
>
> https://patchwork.kernel.org/patch/10621589/
>
> It seems we are stuck there and I don't have the bandwidth to follow up
> with this currently.

Understood. Thanks for the clarification.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-01-24 17:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-12 15:27 [PATCH] soc: imx: gpc: set DMA mask for PD platform devices Lucas Stach
2018-09-13  3:51 ` Fabio Estevam
2018-09-26  2:39 ` Shawn Guo
2019-01-24 11:46   ` Fabio Estevam
2019-01-24 14:34     ` Lucas Stach
2019-01-24 17:41       ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).