* [PATCH] [v2] ARM: omap1: add nand_chip declaration
@ 2018-09-26 14:20 Arnd Bergmann
2018-09-26 14:52 ` Miquel Raynal
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Arnd Bergmann @ 2018-09-26 14:20 UTC (permalink / raw)
To: linux-arm-kernel
Recent MTD changes caused a minor build regression on OMAP1:
In file included from arch/arm/mach-omap1/devices.c:31:
arch/arm/mach-omap1/common.h:85:39: error: 'struct nand_chip' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
Fixes: 1002aed789bc ("mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
----
v2: remove unused linux/mtd/mtd.h inclusion
---
arch/arm/mach-omap1/common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/common.h
index 11b87a4c84d4..504b959ba5cf 100644
--- a/arch/arm/mach-omap1/common.h
+++ b/arch/arm/mach-omap1/common.h
@@ -26,7 +26,6 @@
#ifndef __ARCH_ARM_MACH_OMAP1_COMMON_H
#define __ARCH_ARM_MACH_OMAP1_COMMON_H
-#include <linux/mtd/mtd.h>
#include <linux/platform_data/i2c-omap.h>
#include <linux/reboot.h>
@@ -82,6 +81,7 @@ void omap1_restart(enum reboot_mode, const char *);
extern void __init omap_check_revision(void);
+struct nand_chip;
extern void omap1_nand_cmd_ctl(struct nand_chip *this, int cmd,
unsigned int ctrl);
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] [v2] ARM: omap1: add nand_chip declaration
2018-09-26 14:20 [PATCH] [v2] ARM: omap1: add nand_chip declaration Arnd Bergmann
@ 2018-09-26 14:52 ` Miquel Raynal
2018-09-26 15:30 ` Arnd Bergmann
2018-09-26 14:59 ` Tony Lindgren
2018-10-05 14:37 ` Miquel Raynal
2 siblings, 1 reply; 5+ messages in thread
From: Miquel Raynal @ 2018-09-26 14:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
Arnd Bergmann <arnd@arndb.de> wrote on Wed, 26 Sep 2018 16:20:16 +0200:
> Recent MTD changes caused a minor build regression on OMAP1:
>
> In file included from arch/arm/mach-omap1/devices.c:31:
> arch/arm/mach-omap1/common.h:85:39: error: 'struct nand_chip' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> Fixes: 1002aed789bc ("mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> v2: remove unused linux/mtd/mtd.h inclusion
> ---
> arch/arm/mach-omap1/common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/common.h
> index 11b87a4c84d4..504b959ba5cf 100644
> --- a/arch/arm/mach-omap1/common.h
> +++ b/arch/arm/mach-omap1/common.h
> @@ -26,7 +26,6 @@
> #ifndef __ARCH_ARM_MACH_OMAP1_COMMON_H
> #define __ARCH_ARM_MACH_OMAP1_COMMON_H
>
> -#include <linux/mtd/mtd.h>
> #include <linux/platform_data/i2c-omap.h>
> #include <linux/reboot.h>
>
> @@ -82,6 +81,7 @@ void omap1_restart(enum reboot_mode, const char *);
>
> extern void __init omap_check_revision(void);
>
> +struct nand_chip;
> extern void omap1_nand_cmd_ctl(struct nand_chip *this, int cmd,
> unsigned int ctrl);
>
Boris pointed me that the commit introducing the regression is still
in nand/next, so do you mind if I squash both patches with it?
Regards,
Miqu?l
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] [v2] ARM: omap1: add nand_chip declaration
2018-09-26 14:52 ` Miquel Raynal
@ 2018-09-26 15:30 ` Arnd Bergmann
0 siblings, 0 replies; 5+ messages in thread
From: Arnd Bergmann @ 2018-09-26 15:30 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Sep 26, 2018 at 4:52 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> Arnd Bergmann <arnd@arndb.de> wrote on Wed, 26 Sep 2018 16:20:16 +0200:
> > @@ -82,6 +81,7 @@ void omap1_restart(enum reboot_mode, const char *);
> >
> > extern void __init omap_check_revision(void);
> >
> > +struct nand_chip;
> > extern void omap1_nand_cmd_ctl(struct nand_chip *this, int cmd,
> > unsigned int ctrl);
> >
>
> Boris pointed me that the commit introducing the regression is still
> in nand/next, so do you mind if I squash both patches with it?
No worries, please do that if it makes it easier for you.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] [v2] ARM: omap1: add nand_chip declaration
2018-09-26 14:20 [PATCH] [v2] ARM: omap1: add nand_chip declaration Arnd Bergmann
2018-09-26 14:52 ` Miquel Raynal
@ 2018-09-26 14:59 ` Tony Lindgren
2018-10-05 14:37 ` Miquel Raynal
2 siblings, 0 replies; 5+ messages in thread
From: Tony Lindgren @ 2018-09-26 14:59 UTC (permalink / raw)
To: linux-arm-kernel
* Arnd Bergmann <arnd@arndb.de> [180926 14:26]:
> Recent MTD changes caused a minor build regression on OMAP1:
>
> In file included from arch/arm/mach-omap1/devices.c:31:
> arch/arm/mach-omap1/common.h:85:39: error: 'struct nand_chip' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> Fixes: 1002aed789bc ("mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> v2: remove unused linux/mtd/mtd.h inclusion
Acked-by: Tony Lindgren <tony@atomide.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] [v2] ARM: omap1: add nand_chip declaration
2018-09-26 14:20 [PATCH] [v2] ARM: omap1: add nand_chip declaration Arnd Bergmann
2018-09-26 14:52 ` Miquel Raynal
2018-09-26 14:59 ` Tony Lindgren
@ 2018-10-05 14:37 ` Miquel Raynal
2 siblings, 0 replies; 5+ messages in thread
From: Miquel Raynal @ 2018-10-05 14:37 UTC (permalink / raw)
To: linux-arm-kernel
Hi Arnd,
Arnd Bergmann <arnd@arndb.de> wrote on Wed, 26 Sep 2018 16:20:16 +0200:
> Recent MTD changes caused a minor build regression on OMAP1:
>
> In file included from arch/arm/mach-omap1/devices.c:31:
> arch/arm/mach-omap1/common.h:85:39: error: 'struct nand_chip' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> Fixes: 1002aed789bc ("mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> v2: remove unused linux/mtd/mtd.h inclusion
> ---
Also squashed in nand/next with the failing commit.
Thanks,
Miqu?l
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-10-05 14:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-26 14:20 [PATCH] [v2] ARM: omap1: add nand_chip declaration Arnd Bergmann
2018-09-26 14:52 ` Miquel Raynal
2018-09-26 15:30 ` Arnd Bergmann
2018-09-26 14:59 ` Tony Lindgren
2018-10-05 14:37 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).