From: miquel.raynal@bootlin.com (Miquel Raynal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [v2] ARM: omap1: add nand_chip declaration
Date: Wed, 26 Sep 2018 16:52:40 +0200 [thread overview]
Message-ID: <20180926165240.77a78fc4@xps13> (raw)
In-Reply-To: <20180926142029.619397-1-arnd@arndb.de>
Hi Arnd,
Arnd Bergmann <arnd@arndb.de> wrote on Wed, 26 Sep 2018 16:20:16 +0200:
> Recent MTD changes caused a minor build regression on OMAP1:
>
> In file included from arch/arm/mach-omap1/devices.c:31:
> arch/arm/mach-omap1/common.h:85:39: error: 'struct nand_chip' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>
> Fixes: 1002aed789bc ("mtd: rawnand: plat_nand: Pass a nand_chip object to all platform_nand_ctrl hooks")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> v2: remove unused linux/mtd/mtd.h inclusion
> ---
> arch/arm/mach-omap1/common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/common.h
> index 11b87a4c84d4..504b959ba5cf 100644
> --- a/arch/arm/mach-omap1/common.h
> +++ b/arch/arm/mach-omap1/common.h
> @@ -26,7 +26,6 @@
> #ifndef __ARCH_ARM_MACH_OMAP1_COMMON_H
> #define __ARCH_ARM_MACH_OMAP1_COMMON_H
>
> -#include <linux/mtd/mtd.h>
> #include <linux/platform_data/i2c-omap.h>
> #include <linux/reboot.h>
>
> @@ -82,6 +81,7 @@ void omap1_restart(enum reboot_mode, const char *);
>
> extern void __init omap_check_revision(void);
>
> +struct nand_chip;
> extern void omap1_nand_cmd_ctl(struct nand_chip *this, int cmd,
> unsigned int ctrl);
>
Boris pointed me that the commit introducing the regression is still
in nand/next, so do you mind if I squash both patches with it?
Regards,
Miqu?l
next prev parent reply other threads:[~2018-09-26 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 14:20 [PATCH] [v2] ARM: omap1: add nand_chip declaration Arnd Bergmann
2018-09-26 14:52 ` Miquel Raynal [this message]
2018-09-26 15:30 ` Arnd Bergmann
2018-09-26 14:59 ` Tony Lindgren
2018-10-05 14:37 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180926165240.77a78fc4@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).