From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 28 Sep 2018 17:27:53 -0700 Subject: [PATCH] regulator: core: Pass max_uV value to regulator_set_voltage_rdev In-Reply-To: References: <20180615112916.GK112168@atomide.com> <1529330913-11152-1-git-send-email-m.purski@samsung.com> <20180702080505.GN112168@atomide.com> <95655644-ef41-f5bd-7e8e-a257d48cd020@gmail.com> <20180928202251.GM5662@atomide.com> <2c0132ff-ea0f-f19e-ebfb-a0d077565d2c@gmail.com> <20180928224109.GS5662@atomide.com> Message-ID: <20180929002753.GT5662@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Dmitry Osipenko [180928 23:55]: > On 9/29/18 2:17 AM, Dmitry Osipenko wrote: > > On 9/29/18 1:41 AM, Tony Lindgren wrote: > >> I'm still getting these errors after init: > > > > Thank you very much again, seems I got what's wrong with your case. The ti-abb-regulator driver sets the "abb->current_info_idx = -EINVAL" on probe and that value is getting updated only after the first voltage change, hence _regulator_get_voltage() returns -22. OK that's starting to make some sense now thanks. > > Please try this patch: > > I've revised the patch and here is the current final version. Hey cool this one works now :) I suggest you rework the whole series with these fixes. I recall the series had a problem with git bisect too between the patches. It will make life easier for other people who may need to git bisect these patches. Thanks, Tony