From: jorik@kippendief.biz (Jorik Jonker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dts: sun8i-h3: add sy8106a to orange pi plus
Date: Sat, 29 Sep 2018 15:16:17 +0200 [thread overview]
Message-ID: <20180929131617.GA7940@carbon.kippendief.biz> (raw)
In-Reply-To: <20180928135516.jxhnsgaa3s2nagv7@flea>
Hi,
On Fri, Sep 28, 2018 at 03:55:16PM +0200, Maxime Ripard wrote:
>The prefix of your commit title should be "ARM: dts: ..."
Sure, will fix it in v2.
>> I have tested this on two Orange Pi Plus boards, and they run stable
>> across a range of voltages (and frequencies).
>
>How was this tested?
Basically using intermittent cpuburn runs and monitor freq/voltage/temp.
I've included a description of my test in the v2 commit log.
>> + /*
>> + * The datasheet uses 1.1V as the minimum value of VDD-CPUX,
>> + * however both the Armbian DVFS table and the official one
>> + * have operating points with voltage under 1.1V, and both
>> + * DVFS table are known to work properly at the lowest
>> + * operating point.
>> + *
>> + * Use 1.0V as the minimum voltage instead.
>> + */
>
>There's not much point to that comment, since it's been that way for
>all the other SoCs from Allwinner. However, that would be great to
>have it in the commit log.
Totally agree, but I thought: there must be a good reason this text is
in the PC dts, so let's put it in the Plus dts as well. I've moved it
from the patch to the log in the v2 patch, which I will send right away.
Thanks for reviewing!
Jorik
next prev parent reply other threads:[~2018-09-29 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 8:36 [PATCH] dts: sun8i-h3: add sy8106a to orange pi plus jorik at kippendief.biz
2018-09-28 13:55 ` Maxime Ripard
2018-09-29 13:16 ` Jorik Jonker [this message]
2018-10-01 15:44 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929131617.GA7940@carbon.kippendief.biz \
--to=jorik@kippendief.biz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox