public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: bibby.hsieh@mediatek.com (Bibby Hsieh)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 03/11] drm/mediatek: adjust EDGE to match clock and data
Date: Tue, 2 Oct 2018 16:10:33 +0800	[thread overview]
Message-ID: <20181002081041.32629-4-bibby.hsieh@mediatek.com> (raw)
In-Reply-To: <20181002081041.32629-1-bibby.hsieh@mediatek.com>

From: chunhui dai <chunhui.dai@mediatek.com>

The default timing of DPI data and clock is not match.
We could adjust this bit to make them match.

Signed-off-by: chunhui dai <chunhui.dai@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
---
 drivers/gpu/drm/mediatek/mtk_dpi.c      | 8 ++++++++
 drivers/gpu/drm/mediatek/mtk_dpi_regs.h | 1 +
 2 files changed, 9 insertions(+)

diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c
index 72aa43187731..0ce4b61efaeb 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dpi.c
@@ -114,6 +114,7 @@ struct mtk_dpi_yc_limit {
 
 struct mtk_dpi_conf {
 	u32 reg_h_fre_con;
+	bool edge_sel_en;
 };
 
 static void mtk_dpi_mask(struct mtk_dpi *dpi, u32 offset, u32 val, u32 mask)
@@ -344,6 +345,12 @@ static void mtk_dpi_config_2n_h_fre(struct mtk_dpi *dpi)
 	mtk_dpi_mask(dpi, dpi->conf->reg_h_fre_con, H_FRE_2N, H_FRE_2N);
 }
 
+static void mtk_dpi_config_disable_edge(struct mtk_dpi *dpi)
+{
+	if (dpi->conf->edge_sel_en)
+		mtk_dpi_mask(dpi, dpi->conf->reg_h_fre_con, 0, EDGE_SEL_EN);
+}
+
 static void mtk_dpi_config_color_format(struct mtk_dpi *dpi,
 					enum mtk_dpi_out_color_format format)
 {
@@ -507,6 +514,7 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi,
 	mtk_dpi_config_yc_map(dpi, dpi->yc_map);
 	mtk_dpi_config_color_format(dpi, dpi->color_format);
 	mtk_dpi_config_2n_h_fre(dpi);
+	mtk_dpi_config_disable_edge(dpi);
 	mtk_dpi_sw_reset(dpi, false);
 
 	return 0;
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi_regs.h b/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
index 040444d7718d..d9db8c4cacd7 100644
--- a/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
+++ b/drivers/gpu/drm/mediatek/mtk_dpi_regs.h
@@ -223,5 +223,6 @@
 #define ESAV_CODE2			(0xFFF << 0)
 #define ESAV_CODE3_MSB			BIT(16)
 
+#define EDGE_SEL_EN			BIT(5)
 #define H_FRE_2N			BIT(25)
 #endif /* __MTK_DPI_REGS_H */
-- 
2.12.5.2.gbdf23ab

  parent reply	other threads:[~2018-10-02  8:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-02  8:10 [PATCH v4 00/11] drm/mediatek: support hdmi output for mt2701 and mt7623 Bibby Hsieh
2018-10-02  8:10 ` [PATCH v4 01/11] drm/mediatek: add refcount for DPI power on/off Bibby Hsieh
2018-10-02  8:28   ` CK Hu
2018-10-02  8:10 ` [PATCH v4 02/11] drm/mediatek: move hardware register to node data Bibby Hsieh
2018-10-02  8:10 ` Bibby Hsieh [this message]
2018-10-02  8:10 ` [PATCH v4 04/11] drm/mediatek: add clock factor for different IC Bibby Hsieh
2018-10-02  8:10 ` [PATCH v4 05/11] drm/mediatek: convert dpi driver to use drm_of_find_panel_or_bridge Bibby Hsieh
2018-10-02  8:32   ` CK Hu
2018-10-02  8:10 ` [PATCH v4 06/11] drm/mediatek: add dpi driver for mt2701 and mt7623 Bibby Hsieh
2018-10-02  8:10 ` [PATCH v4 07/11] drm/mediatek: separate hdmi phy to different file Bibby Hsieh
2018-10-02  8:40   ` CK Hu
2018-10-02  8:10 ` [PATCH v4 08/11] drm/mediatek: add support for SPDIF audio in HDMI Bibby Hsieh
2018-10-02  8:10 ` [PATCH v4 09/11] drm/mediatek: add hdmi driver for MT2701 and MT7623 Bibby Hsieh
2018-10-02  8:10 ` [PATCH v4 10/11] drm/mediatek: implement connection from BLS to DPI0 Bibby Hsieh
2018-10-02  8:10 ` [PATCH v4 11/11] drm/mediatek: add a error return value when clock driver has been prepared Bibby Hsieh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181002081041.32629-4-bibby.hsieh@mediatek.com \
    --to=bibby.hsieh@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox