From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: clearfog-gt-8k: add PCIe slot description
Date: Wed, 3 Oct 2018 15:31:10 +0200 [thread overview]
Message-ID: <20181003133110.GD427@lunn.ch> (raw)
In-Reply-To: <ac8d233a624411272616d19f070cea756f625235.1538572981.git.baruch@tkos.co.il>
On Wed, Oct 03, 2018 at 04:23:01PM +0300, Baruch Siach wrote:
> This adds support for the PCIe interface on the CON4 mini-PCIe
> connector.
Hi Baruch
Is there a dependency between this and the implementation of the
reset-gpios? It would be good to at least mention if there is/is not
such a dependency. You could put it under the ---.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> index 2e06d82bec58..a13549749ee7 100644
> --- a/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> +++ b/arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
> @@ -233,6 +233,13 @@
> };
> };
>
> +&cp0_pcie0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&cp0_pci0_reset_pins>;
> + reset-gpios = <&cp0_gpio2 0 GPIO_ACTIVE_LOW>;
> + status = "okay";
> +};
> +
> &cp0_gpio2 {
> sata_reset {
> gpio-hog;
> --
> 2.19.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-10-03 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-03 13:23 [PATCH] arm64: dts: clearfog-gt-8k: add PCIe slot description Baruch Siach
2018-10-03 13:31 ` Andrew Lunn [this message]
2018-10-03 13:43 ` Baruch Siach
2018-10-03 15:22 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181003133110.GD427@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).