From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris.brezillon@bootlin.com (Boris Brezillon) Date: Thu, 4 Oct 2018 11:26:08 +0200 Subject: [PATCH 4/4] arm64: dts: lx2160a: update fspi node In-Reply-To: References: <1538642920-3843-1-git-send-email-yogeshnarayan.gaur@nxp.com> <1538642920-3843-5-git-send-email-yogeshnarayan.gaur@nxp.com> <20181004111822.48ab1f5c@bbrezillon> Message-ID: <20181004112608.3ae23d99@bbrezillon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 4 Oct 2018 09:24:57 +0000 Yogesh Narayan Gaur wrote: > Hi Boris, > > > -----Original Message----- > > From: Boris Brezillon [mailto:boris.brezillon at bootlin.com] > > Sent: Thursday, October 4, 2018 2:48 PM > > To: Yogesh Narayan Gaur > > Cc: linux-mtd at lists.infradead.org; marek.vasut at gmail.com; vigneshr at ti.com; > > linux-spi at vger.kernel.org; devicetree at vger.kernel.org; robh at kernel.org; > > mark.rutland at arm.com; shawnguo at kernel.org; linux-arm- > > kernel at lists.infradead.org; computersforpeace at gmail.com; > > frieder.schrempf at exceet.de; linux-kernel at vger.kernel.org > > Subject: Re: [PATCH 4/4] arm64: dts: lx2160a: update fspi node > > > > On Thu, 4 Oct 2018 14:18:40 +0530 > > Yogesh Gaur wrote: > > > > > Flash mt35xu512aba connected to FlexSPI controller supports > > > 1-1-8 protocol. > > > Added flag spi-rx-bus-width and spi-tx-bus-width with values as > > > 8 and 1 respectively for both flashes connected at CS0 and CS1. > > > > > > Signed-off-by: Yogesh Gaur > > > --- > > > arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > > > b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > > > index 901ca346..817175a 100644 > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts > > > @@ -42,6 +42,8 @@ > > > m25p,fast-read; > > > spi-max-frequency = <20000000>; > > > reg = <0>; > > > + spi-rx-bus-width = <8>; > > > + spi-tx-bus-width = <1>; > > > > Why 1? The flash is already flagged with SPI_NOR_OCTAL_READ, which means > > only the read path will use 1-1-8 mode, so you can safely set spi-tx-bus-width I meant 'set spi-tx-bus-width to 8' here > > here and let the framework choose the appropriate mode based on the flash > > capabilities. > > Ok. > > > > > > }; > > > > > > mt35xu512aba1: flash at 1 { > > > @@ -51,6 +53,8 @@ > > > m25p,fast-read; > > > spi-max-frequency = <20000000>; > > > reg = <1>; > > > + spi-rx-bus-width = <8>; > > > + spi-tx-bus-width = <1>; > > > }; > > > }; > > > >