From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: mm: Use __pa_symbol() for set_swapper_pgd()
Date: Wed, 10 Oct 2018 17:57:41 +0100 [thread overview]
Message-ID: <20181010165740.GD212880@arrakis.emea.arm.com> (raw)
In-Reply-To: <20181010144322.14363-1-james.morse@arm.com>
On Wed, Oct 10, 2018 at 03:43:22PM +0100, James Morse wrote:
> commit 2330b7ca78350efcb ("arm64/mm: use fixmap to modify
> swapper_pg_dir") modifies the swapper_pg_dir via the fixmap
> as the kernel page tables have been moved to a read-only
> part of the kernel mapping.
>
> Using __pa() to setup the fixmap causes CONFIG_DEBUG_VIRTUAL
> to fire, as this function is used on the kernel-image swapper
> address. The in_swapper_pgdir() test before each call of this
> function means set_swapper_pgd() will only ever be called when
> pgdp points somewhere in the kernel-image mapping of
> swapper_pd_dir. Use __pa_symbol().
>
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Signed-off-by: James Morse <james.morse@arm.com>
> CC: Jun Yao <yaojun8558363@gmail.com>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied. Thanks.
--
Catalin
prev parent reply other threads:[~2018-10-10 16:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 14:43 [PATCH] arm64: mm: Use __pa_symbol() for set_swapper_pgd() James Morse
2018-10-10 14:52 ` Will Deacon
2018-10-10 16:57 ` Catalin Marinas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181010165740.GD212880@arrakis.emea.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).