From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: sun4i-i2s: don't try to start up or shut down DAI if it's active
Date: Fri, 12 Oct 2018 18:45:43 +0200 [thread overview]
Message-ID: <20181012164543.GF2340@sirena.org.uk> (raw)
In-Reply-To: <7437935.iAfLsdZGOz@anarsoul-thinkpad>
On Fri, Oct 12, 2018 at 09:28:56AM -0700, Vasily Khoruzhick wrote:
> On Friday, October 12, 2018 9:09:05 AM PDT Mark Brown wrote:
> > On Fri, Oct 12, 2018 at 08:32:54AM -0700, Vasily Khoruzhick wrote:
> > > Otherwise we may end up with shutting down I2S if shutdown() was
> > > called for capture substream, but playback is still running.
> > Would it be cleaner and more robust to use runtime PM? I'm wondering
> > what happens if some of the configuration stuff turns out to also need
> > some of the clocks for example.
> I guess. I'm not sure why this code was put into startup and shutdown
> callbacks in first place.
> Maybe Marcus or Maxime know?
> As for configuration - only bus clock is necessary for configuration and it's
> already enabled in runtime_resume() callback.
Probably these really are only needed when audio is active so it's
saving that little bit of power in which case your fix looks good to me
but I'll leave a chance for the people with system specific knowledge to
review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20181012/18d50e17/attachment.sig>
next prev parent reply other threads:[~2018-10-12 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-12 15:32 [PATCH] ASoC: sun4i-i2s: don't try to start up or shut down DAI if it's active Vasily Khoruzhick
2018-10-12 16:09 ` Mark Brown
2018-10-12 16:28 ` Vasily Khoruzhick
2018-10-12 16:45 ` Mark Brown [this message]
2018-10-15 8:11 ` Maxime Ripard
2018-10-15 15:13 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181012164543.GF2340@sirena.org.uk \
--to=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox