[PATCH] mfd: db8500-prcmu: Fix some section annotations

[PATCH] mfd: db8500-prcmu: Fix some section annotations

[Nathan Chancellor]

When building the kernel with Clang, the following section mismatch
warnings appear:

WARNING: vmlinux.o(.text+0x7239cc): Section mismatch in reference from
the function db8500_prcmu_probe() to the function
.init.text:init_prcm_registers()
The function db8500_prcmu_probe() references
the function __init init_prcm_registers().
This is often because db8500_prcmu_probe lacks a __init
annotation or the annotation of init_prcm_registers is wrong.

WARNING: vmlinux.o(.text+0x723e28): Section mismatch in reference from
the function db8500_prcmu_probe() to the function
.init.text:fw_project_name()
The function db8500_prcmu_probe() references
the function __init fw_project_name().
This is often because db8500_prcmu_probe lacks a __init
annotation or the annotation of fw_project_name is wrong.

db8500_prcmu_probe should not be marked as __init so remove the __init
annotation from fw_project_name and init_prcm_registers.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
 drivers/mfd/db8500-prcmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 5970b8def548..aec20e1c7d3d 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -2584,7 +2584,7 @@ static struct irq_chip prcmu_irq_chip = {
 	.irq_unmask	= prcmu_irq_unmask,
 };
 
-static __init char *fw_project_name(u32 project)
+static char *fw_project_name(u32 project)
 {
 	switch (project) {
 	case PRCMU_FW_PROJECT_U8500:
@@ -2732,7 +2732,7 @@ void __init db8500_prcmu_early_init(u32 phy_base, u32 size)
 	INIT_WORK(&mb0_transfer.mask_work, prcmu_mask_work);
 }
 
-static void __init init_prcm_registers(void)
+static void init_prcm_registers(void)
 {
 	u32 val;
 
-- 
2.19.1

[PATCH] mfd: db8500-prcmu: Fix some section annotations

[Lee Jones]

On Wed, 17 Oct 2018, Nathan Chancellor wrote:

> When building the kernel with Clang, the following section mismatch
> warnings appear:
> 
> WARNING: vmlinux.o(.text+0x7239cc): Section mismatch in reference from
> the function db8500_prcmu_probe() to the function
> .init.text:init_prcm_registers()
> The function db8500_prcmu_probe() references
> the function __init init_prcm_registers().
> This is often because db8500_prcmu_probe lacks a __init
> annotation or the annotation of init_prcm_registers is wrong.
> 
> WARNING: vmlinux.o(.text+0x723e28): Section mismatch in reference from
> the function db8500_prcmu_probe() to the function
> .init.text:fw_project_name()
> The function db8500_prcmu_probe() references
> the function __init fw_project_name().
> This is often because db8500_prcmu_probe lacks a __init
> annotation or the annotation of fw_project_name is wrong.
> 
> db8500_prcmu_probe should not be marked as __init so remove the __init
> annotation from fw_project_name and init_prcm_registers.
> 
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
>  drivers/mfd/db8500-prcmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied for v4.21, thanks.

-- 
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog