From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Log the Fault Status Code (FSC) upon memory aborts
Date: Fri, 26 Oct 2018 09:33:18 +0100 [thread overview]
Message-ID: <20181026083318.xbeo3drinb5ptiba@blommer> (raw)
In-Reply-To: <1540512876-12011-1-git-send-email-sudaraja@codeaurora.org>
On Thu, Oct 25, 2018 at 05:14:36PM -0700, Sudarshan Rajagopalan wrote:
> When decoding the information from ESR on mem faults, log the
> FSC value, which is commonly shared for Data and Instruction aborts.
Given we extract the other fields, extracting the FSC makes sense to me.
>
> Change-Id: If7d7f6027958864d99dfb7e79d368e82415dce97
Please drop any Change-Id tag when sending patches upstream.
> Signed-off-by: Sudarshan Rajagopalan <sudaraja@codeaurora.org>
> ---
> arch/arm64/mm/fault.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/mm/fault.c b/arch/arm64/mm/fault.c
> index b8eecc7..e9d07ab 100644
> --- a/arch/arm64/mm/fault.c
> +++ b/arch/arm64/mm/fault.c
> @@ -120,6 +120,7 @@ static void mem_abort_decode(unsigned int esr)
> pr_alert(" EA = %lu, S1PTW = %lu\n",
> (esr & ESR_ELx_EA) >> ESR_ELx_EA_SHIFT,
> (esr & ESR_ELx_S1PTW) >> ESR_ELx_S1PTW_SHIFT);
> + pr_alert(" FSC = %lu\n", (esr & ESR_ELx_FSC));
I think it would make sense to log this immediately after the ESR and decoded
exception class, before the other fault fields.
It would be nice if we could factor out the strings from the fault_info table,
so that we can print a human-readable string as we do for the ESR, but I think
that can be a future addition.
FWIW, with this moved immediately after the dump of the ESR (and decoded ESR
string):
Acked-by: Mark Rutland <mark.rutland@arm.com>
Mark.
>
> if (esr_is_data_abort(esr))
> data_abort_decode(esr);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2018-10-26 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-26 0:14 [PATCH] arm64: Log the Fault Status Code (FSC) upon memory aborts Sudarshan Rajagopalan
2018-10-26 8:33 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181026083318.xbeo3drinb5ptiba@blommer \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox